Add CORS support #10546
Merged
Add CORS support #10546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
mheon
reviewed
Jun 3, 2021
|
@rhatdan I am now figuring out a way to test this. It seems like I will have to come up with a solution from scratch. |
jwhonce
requested changes
Jun 3, 2021
pkg/api/server/handler_api.go
Outdated
| @@ -63,6 +63,12 @@ func (s *APIServer) APIHandler(h http.HandlerFunc) http.HandlerFunc { | |||
| w.Header().Set("Libpod-API-Version", lv) | |||
| w.Header().Set("Server", "Libpod/"+lv+" ("+runtime.GOOS+")") | |||
|
|
|||
| if s.CorsHeaders != "" { | |||
| w.Header().Set("Access-Control-Allow-Origin", s.CorsHeaders) | |||
| w.Header().Set("Access-Control-Allow-Headers", "Origin, X-Requested-With, Content-Type, Accept, X-Registry-Auth") | |||
There was a problem hiding this comment.
Do we need "Connection" and "Upgrade" in this header list?
We do need "X-Registry-Config".
|
Changes LGTM once tests and @jwhonce 's concerns are addressed |
|
gack, hit the wrong button, didn't mean to close. |
[NO TESTS NEEDED] Signed-off-by: Boaz Shuster <[email protected]>
jwhonce
approved these changes
Jun 4, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: boaz0, jwhonce, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.