Fix permissions on initially created named volumes #10531
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@mheon PTAL |
rhatdan
force-pushed
the
volume
branch
4 times, most recently
from
0db10db to
4a48ed1
Compare
libpod/container_internal.go
Outdated
| @@ -1734,6 +1734,15 @@ func (c *Container) chownVolume(volumeName string) error { | |||
| if err := os.Lchown(mountPoint, uid, gid); err != nil { | |||
| return err | |||
| } | |||
|
|
|||
| st, err := os.Lstat(filepath.Join(c.state.Mountpoint, v.Dest)) | |||
There was a problem hiding this comment.
Could you add a comment here? Maybe also mention #10188 for historical reasons.
| @@ -904,6 +904,18 @@ USER bin`, BB) | |||
| Expect(session.ExitCode()).To(Equal(100)) | |||
| }) | |||
|
|
|||
| It("podman run with named volume", func() { | |||
There was a problem hiding this comment.
Can you drop a comment that points to #10188?
There was a problem hiding this comment.
Why, this fixes the permissions of the volume created, I don't believe we care about the timestamps.
There was a problem hiding this comment.
Ok It now handled timestamps.
rhatdan
force-pushed
the
volume
branch
2 times, most recently
from
2491338 to
4581de8
Compare
|
All kinds of test unhappiness @Rhadan |
rhatdan
force-pushed
the
volume
branch
2 times, most recently
from
668c6df to
b37ccb2
Compare
|
Fixes: #10606 |
|
LGTM |
Permission of volume should match the directory it is being mounted on. Fixes: containers#10188 Signed-off-by: Daniel J Walsh <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Permission of volume should match the directory it is being mounted on.
Fixes: #10188
Signed-off-by: Daniel J Walsh [email protected]