Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check for PodStateExited when pruning pods #10449

Closed
wants to merge 1 commit into from

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented May 24, 2021

[NO TESTS NEEDED] This is an attempt to fix a Race condition
since it is a race it is difficult to fix test.

Helps fix: #7139

Signed-off-by: Daniel J Walsh [email protected]

[NO TESTS NEEDED] This is an attempt to fix a Race condition
since it is a race it is difficult to fix.

Helps fix: containers#7139

Signed-off-by: Daniel J Walsh <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2021
@rhatdan
Copy link
Member Author

rhatdan commented May 24, 2021

@edsantiago PTAL

@edsantiago
Copy link
Member

I'll keep my fingers crossed.

I'm seeing a HUGE number of flakes in the podman start --all test, which has nothing to do with pods, so I think there might be two separate issues. This one LGTM though.

@rhatdan
Copy link
Member Author

rhatdan commented May 24, 2021

The --start=all is brand new, so I can take a look tomorrow,

@edsantiago
Copy link
Member

I'm not sure it has to do with start --all. My working hypothesis, which I'll start work on tomorrow, is that it has to do with podman rm cid1 cid2 cid3 (a list of multiple CIDs). But it could also be related to rmi of a container that has been restarted. Anyhow, more tomorrow. Thanks for this one.

@edsantiago
Copy link
Member

@rhatdan
Copy link
Member Author

rhatdan commented May 25, 2021

I think my other PR will fix all of them.

@rhatdan rhatdan closed this May 25, 2021
@rhatdan
Copy link
Member Author

rhatdan commented May 25, 2021

#10452

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rootless: pods: unlinkat, EBUSY
2 participants