Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] docs: generate systemd: XDG_RUNTIME_DIR #10399

Merged
merged 1 commit into from
May 19, 2021

Conversation

vrothberg
Copy link
Member

A conversation on the customer portal suggests that to add an extra note
about the requirement of XDG_RUNTIME_DIR to be set.

Signed-off-by: Valentin Rothberg [email protected]

A conversation on the customer portal suggests that to add an extra note
about the requirement of XDG_RUNTIME_DIR to be set.

Signed-off-by: Valentin Rothberg <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2021
@vrothberg vrothberg changed the title docs: generate systemd: XDG_RUNTIME_DIR [CI:DOCS] docs: generate systemd: XDG_RUNTIME_DIR May 19, 2021
@vrothberg
Copy link
Member Author

@containers/podman-maintainers PTAL

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's so special about podman generate systemd that it requires setting XDG_RUNTIME_DIR? Shouldn't this apply to all rootless podman commands?

@vrothberg
Copy link
Member Author

What's so special about podman generate systemd that it requires setting XDG_RUNTIME_DIR?

There was a customer issue where this information would have helped the customer to immediately resolve the issue.

Shouldn't this apply to all rootless podman commands?

Yes and no. Podman is able to figure out the path on its own, if the variable isn't set. The man pages for generate systemd, however, need systemctl and journalctl to work which in turn require the variable to be set.

@rhatdan
Copy link
Member

rhatdan commented May 19, 2021

LGTM

@Luap99
Copy link
Member

Luap99 commented May 19, 2021

Thanks for clarification.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2021
@openshift-merge-robot openshift-merge-robot merged commit 4c75626 into containers:master May 19, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants