fix: response of containers wait endpoint #10371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be also omitted, but I don't know how to assert that. |
matejvasek
force-pushed
the
fix-wait-compat
branch
from
162b12c to
fb35721
Compare
matejvasek
force-pushed
the
fix-wait-compat
branch
from
fb35721 to
8873ac8
Compare
|
Changes LGTM, but it looks like you need a rebase @matejvasek |
The `Error` part of response must be nil (or omitted) if no error occurred. Before this commit a zero value for the struct was returned. Signed-off-by: Matej Vasek <[email protected]>
matejvasek
force-pushed
the
fix-wait-compat
branch
from
8873ac8 to
92e8589
Compare
|
@TomSweeneyRedHat rebased |
|
/lgtm |
|
/approved |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Errorpart of response must be nil if no error occurred.Before this commit a zero value for the struct was returned.
Signed-off-by: Matej Vasek [email protected]