Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting and indentation in network http api docs #10369

Merged

Conversation

jmguzik
Copy link
Contributor

@jmguzik jmguzik commented May 17, 2021

Formatting aligned to observed here:
https://docs.docker.com/engine/api/v1.41/#operation/NetworkList

  • fix some indentation issues.

[NO TESTS NEEDED]

@TomSweeneyRedHat
Copy link
Member

@jmguzik thanks for the PR. The changes LGTM, but the tests are unhappy and I can't quickly figure out why. Maybe a known flake @edsantiago ?

@edsantiago
Copy link
Member

Compose tests always flake these days. I've restarted.

int test failure is weird:

Failed to create /user.slice/user-13251.slice/session-3.scope/init.scope control group: Permission denied
Failed to allocate manager object: Permission denied
Failed to allocate manager object, freezing.
Freezing execution.

I'm just going to restart it and hope it was a flake.

@rhatdan
Copy link
Member

rhatdan commented May 18, 2021

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmguzik, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2021
@openshift-merge-robot openshift-merge-robot merged commit 959d6a0 into containers:master May 18, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants