Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match swagger to "as built" output #10365

Merged
merged 1 commit into from
May 21, 2021

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented May 17, 2021

  • Remove all Types no longer referenced, they were never used

A future API breaking version of Podman API, may restore these Types
and push formatting into presentation layer vs. server.

Fixes #9578

Signed-off-by: Jhon Honce [email protected]

@jwhonce jwhonce added kind/bug Categorizes issue or PR as related to a bug. HTTP API Bug is in RESTful API labels May 17, 2021
@jwhonce jwhonce self-assigned this May 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021
@rhatdan
Copy link
Member

rhatdan commented May 17, 2021

@jwhonce Do we need tests?

@jwhonce jwhonce force-pushed the issues/9578 branch 5 times, most recently from 3c13970 to 92ca508 Compare May 20, 2021 21:03
@TomSweeneyRedHat
Copy link
Member

Tests are still not hip @jwhonce
Changes LGTM fwiw

* Remove all Types no longer referenced, they were never used

A future API breaking version of Podman API, may restore these Types
and push formatting into presentation layer vs. server.

Fixes containers#9578

Signed-off-by: Jhon Honce <[email protected]>
@baude
Copy link
Member

baude commented May 21, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2021
@openshift-merge-robot openshift-merge-robot merged commit 490915c into containers:master May 21, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. HTTP API Bug is in RESTful API kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

swagger type mismatch for the /libpod/images/{name:.*}/tree endpoint
5 participants