Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go.sum #10331

Merged
merged 1 commit into from
May 14, 2021
Merged

Update go.sum #10331

merged 1 commit into from
May 14, 2021

Conversation

font
Copy link
Contributor

@font font commented May 13, 2021

Running make vendor to add a missing dependency hash.

@font
make vendor
b9b3860 
Signed-off-by: Ivan Font <[email protected]>
@TomSweeneyRedHat
Copy link
Member

LGTM but would like @vrothberg to give this an eyeball. I'm not sure why past vendors didn't make this change?

@mheon
Copy link
Member

mheon commented May 13, 2021

LGTM. Dependabot seems broken at the moment, which is a damn pity because it was working so well.

giuseppe
giuseppe approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: font, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2021
@Luap99
Copy link
Member

Luap99 commented May 14, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit d05cc0a into containers:master May 14, 2021
@font font deleted the vendor branch May 14, 2021 19:02
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe giuseppe approved these changes

Assignees

@giuseppe giuseppe

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@font @TomSweeneyRedHat @mheon @Luap99 @giuseppe @openshift-merge-robot