Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use UTC for containers/{name}/json endpoint #10286

Merged
merged 1 commit into from
May 10, 2021

Conversation

matejvasek
Copy link
Contributor

Reason: docker daemon uses timestamps in UTC not local date.

resolves: #10267

@matejvasek matejvasek changed the title fix: use UTC for containers/{name or id}/json endpoint fix: use UTC for containers/{name}/json endpoint May 10, 2021
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits and the ask to add a test.

libpod/container_internal_linux.go Outdated Show resolved Hide resolved
pkg/api/handlers/compat/containers.go Show resolved Hide resolved
pkg/api/handlers/compat/containers.go Outdated Show resolved Hide resolved
pkg/api/handlers/compat/containers.go Outdated Show resolved Hide resolved
@matejvasek
Copy link
Contributor Author

@vrothberg PTAL

@mheon
Copy link
Member

mheon commented May 10, 2021 via email

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vrothberg
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2021
@vrothberg
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2021
@openshift-merge-robot openshift-merge-robot merged commit 821aea7 into containers:master May 10, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker compatibility: Timestamps are a different format than docker
4 participants