-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use UTC for containers/{name}/json
endpoint
#10286
fix: use UTC for containers/{name}/json
endpoint
#10286
Conversation
containers/{name or id}/json
endpointcontainers/{name}/json
endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits and the ask to add a test.
Signed-off-by: Matej Vasek <[email protected]>
@vrothberg PTAL |
Reluctant LGTM. As Dan says: Bug for Bug.
…On Mon, May 10, 2021 at 05:22 Matej Vasek ***@***.***> wrote:
@vrothberg <https://github.com/vrothberg> PTAL
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10286 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3AOCFRAUTR3BBVVD5O3JTTM6QU5ANCNFSM44QSXJZA>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason: docker daemon uses timestamps in UTC not local date.
resolves: #10267