Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cli network prune --filter flag #10254

Merged
merged 2 commits into from
May 14, 2021
Merged

Add support for cli network prune --filter flag #10254

merged 2 commits into from
May 14, 2021

Conversation

jmguzik
Copy link
Contributor

@jmguzik jmguzik commented May 6, 2021

Missing cli functionality added.
/kind feature

@openshift-ci-robot openshift-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 6, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmguzik
To complete the pull request process, please assign zhangguanzhang after the PR has been reviewed.
You can assign the PR to them by writing /assign @zhangguanzhang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmguzik jmguzik force-pushed the prune-filter-cli branch from 810451a to 6dbd772 Compare May 6, 2021 22:44
@TomSweeneyRedHat
Copy link
Member

All kinds of unhappy red tests @jmguzik

@jmguzik
Copy link
Contributor Author

jmguzik commented May 8, 2021

All kinds of unhappy red tests @jmguzik

Does not work as expected... I will try to have a closer look in the next few days.

@jmguzik jmguzik force-pushed the prune-filter-cli branch 5 times, most recently from 25372e4 to 058177c Compare May 11, 2021 22:39
@jmguzik jmguzik force-pushed the prune-filter-cli branch from 058177c to 2a502aa Compare May 12, 2021 06:50
@jmguzik jmguzik force-pushed the prune-filter-cli branch from 2a502aa to 5e64053 Compare May 12, 2021 07:05
@jmguzik jmguzik marked this pull request as ready for review May 12, 2021 08:26
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2021
@jmguzik jmguzik requested a review from TomSweeneyRedHat May 12, 2021 10:57
@jmguzik jmguzik mentioned this pull request May 14, 2021
Merged
@rhatdan
Copy link
Member

rhatdan commented May 14, 2021

LGTM
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmguzik, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2021
@Luap99
Copy link
Member

Luap99 commented May 14, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit fabaa25 into containers:master May 14, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat Awaiting requested review from TomSweeneyRedHat

Assignees

@Luap99 Luap99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jmguzik @openshift-ci-robot @TomSweeneyRedHat @rhatdan @Luap99 @openshift-merge-robot