Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nix pin with make nixpkgs #10239

Merged
merged 1 commit into from
May 12, 2021
Merged

Update nix pin with make nixpkgs #10239

merged 1 commit into from
May 12, 2021

Conversation

hswong3i
Copy link
Collaborator

@hswong3i hswong3i commented May 6, 2021

Signed-off-by: Wong Hoi Sing Edison [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hswong3i
To complete the pull request process, please assign vrothberg after the PR has been reviewed.
You can assign the PR to them by writing /assign @vrothberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vrothberg
vrothberg reviewed May 11, 2021
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restarted the flake.
LGTM, @containers/podman-maintainers PTAL

@TomSweeneyRedHat
Copy link
Member

upgrade tests are unhappy, were those the flakes @vrothberg ?

@hswong3i
Update nix pin with make nixpkgs
9ac1248 
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
@hswong3i hswong3i force-pushed the master-linux-amd64 branch from 874f43e to 9ac1248 Compare May 12, 2021 01:19
@vrothberg
Copy link
Member

upgrade tests are unhappy, were those the flakes @vrothberg ?

No, initially the validate job flaked due to a CI infra hiccup. CI gods do not shine upon this PR. Restarted the next flakes.

@hswong3i
Copy link
Collaborator Author

@TomSweeneyRedHat force pushed, CI passed

@vrothberg
Copy link
Member

@containers/podman-maintainers PTAL and merge

saschagrunert
saschagrunert approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2021
@rhatdan
Copy link
Member

rhatdan commented May 12, 2021

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hswong3i, rhatdan, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [rhatdan,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7b59119 into containers:master May 12, 2021
@edsantiago edsantiago mentioned this pull request May 18, 2021
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hswong3i @openshift-ci-robot @TomSweeneyRedHat @vrothberg @rhatdan @saschagrunert @openshift-merge-robot