Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Minor podmanimage docs updates. #10227

Merged
merged 1 commit into from
May 5, 2021

Conversation

cevich
Copy link
Member

@cevich cevich commented May 5, 2021

Discovered by review of
containers/buildah#3200

Signed-off-by: Chris Evich [email protected]

@cevich cevich requested a review from TomSweeneyRedHat May 5, 2021 17:54
@cevich cevich force-pushed the podman_image_docs branch 3 times, most recently from d47b913 to 8c32c0c Compare May 5, 2021 18:02
@cevich
Copy link
Member Author

cevich commented May 5, 2021

@TomSweeneyRedHat okay this one should be good now. I manually verified clicking on the links now works properly.

@rhatdan
Copy link
Member

rhatdan commented May 5, 2021

LGTM
/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2021
@TomSweeneyRedHat
Copy link
Member

One last, then GTG

Discovered by review of
containers/buildah#3200

Signed-off-by: Chris Evich <[email protected]>
@cevich cevich force-pushed the podman_image_docs branch from 8c32c0c to 914eab0 Compare May 5, 2021 18:59
@jwhonce
Copy link
Member

jwhonce commented May 5, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2021
@openshift-merge-robot openshift-merge-robot merged commit db48da4 into containers:master May 5, 2021
@cevich cevich deleted the podman_image_docs branch June 30, 2021 17:59
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants