[CI:DOCS] Several multi-arch image build/push fixes #10123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cevich
changed the title
cevich
force-pushed
the
fix_multi_arch_image
branch
from
1c68f13 to
d5d6d50
Compare
|
@edsantiago I snuck in your 'append' suggestion here along with splitting that |
* Fix not setting `$VERSION` before reference
* Reduce need for "syntax-hilighting workaround` comment.
Simplify context-expressions -> simple env. var. referenmces
* Fix pushing quay.io/containers/podman:master twice
('upstream' and 'testing' matrix items)
* Throw error on unknown/unsupported matrix items
* Improve readability of setting multi-line `$LABELS` value.
Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
fix_multi_arch_image
branch
from
d5d6d50 to
1e98a95
Compare
|
@TomSweeneyRedHat @edsantiago I think this is ready. PTAL. |
|
LGTM |
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$VERSIONbefore referenceSimplify context-expressions -> simple env. var. referenmces
('upstream' and 'testing' matrix items)
$LABELSvalue.