Ensure mount destination is clean, no trailing slash #10069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luap99
reviewed
Apr 17, 2021
test/e2e/play_kube_test.go
Outdated
| @@ -1861,6 +1861,54 @@ spec: | |||
| Expect(inspect.OutputToString()).To(ContainSubstring(correct)) | |||
| }) | |||
|
|
|||
| FIt("podman play kube test duplicate volume destination between Host path and image volumes", func() { | |||
There was a problem hiding this comment.
Suggested change
| FIt("podman play kube test duplicate volume destination between Host path and image volumes", func() { | |
| It("podman play kube test duplicate volume destination between Host path and image volumes", func() { |
EduardoVega
force-pushed
the
clean-mounts-9618
branch
from
7986688 to
c633ced
Compare
|
Clean should be a few lines higher, so the earlier check for existing
mounts uses the cleaned path
…On Sat, Apr 17, 2021 at 13:52 Eduardo Vega ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In test/e2e/play_kube_test.go
<#10069 (comment)>:
> @@ -1861,6 +1861,54 @@ spec:
Expect(inspect.OutputToString()).To(ContainSubstring(correct))
})
+ FIt("podman play kube test duplicate volume destination between Host path and image volumes", func() {
Fixed
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10069 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3AOCHUMPB6UTHOPZDRHQ3TJHDE7ANCNFSM43DIPUTQ>
.
|
Signed-off-by: Eduardo Vega <[email protected]>
EduardoVega
force-pushed
the
clean-mounts-9618
branch
from
c633ced to
18d462c
Compare
|
@mheon thanks. I have made the change |
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EduardoVega, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@Luap99 @baude we got a compose-test flake, is that output useful to you? |
|
@edsantiago I created #10052 to track the flake. |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HostPath volumes specified in kube Pod YAMLs were not being cleaned (remove trailing slash), while named volumes specified in Dockerfiles / Containerfiles with the VOLUME instruction were being cleaned. This provoked that two volumes were mounted because the destination was not the same due to the trailing slash.
Fix #9618
Signed-off-by: Eduardo Vega [email protected]