Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system tests: build --pull-never: deal with flakes #10046

Merged
merged 1 commit into from
Apr 16, 2021
Merged

system tests: build --pull-never: deal with flakes #10046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions test/system/070-build.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,8 +691,16 @@ RUN echo $random_string
EOF

run_podman 125 build -t build_test --pull-never $tmpdir
is "$output" ".* pull policy is .never. but .* could not be found locally" \
"--pull-never fails with expected error message"
# FIXME: this is just ridiculous. Even after #10030 and #10034, Ubuntu
# remote *STILL* flakes this test! It fails with the correct exit status,
# but the error output is 'Error: stream dropped, unexpected failure'
# Let's just stop checking on podman-remote. As long as it exits 125,
# we're happy.
if ! is_remote; then
is "$output" \
".* pull policy is .never. but .* could not be found locally" \
"--pull-never fails with expected error message"
fi
}

@test "podman build --logfile test" {
Expand Down