fix build with with GO111MODULE=off

[lsm5]

Fix build with GO111MODULE=off

Distro builds on Fedora and Kubic projects use GO111MODULE=off
by default which are currently failing. This commit fixes it and
going forward, podman CI will also indicate failures in rpm builds.

conmon build has also been removed from podman.spec.in because the COPR
for which it was provided has been discontinued.

Fixes: #10009

Signed-off-by: Lokesh Mandvekar [email protected]

@mheon @vrothberg @rhatdan @baude @cevich PTAL

[lsm5]

let me add a CI job for GO111MODULE=off

[mheon]

This seems OK, LGTM

[vrothberg]

LGTM

[vrothberg]

/lgtm
/hold

[lsm5]

Let's hold off on lgtm until we have a green CI.

[cevich]

@lsm5 I'm curious why this is needed. My understanding is GO111MODULE=off is only necessary when using really, really, old versions of golang, no?

---

CI test-job wise, this sounds like something ripe for inclusion in alt_build_task. This is a kind of catch-all for "Confirm building works in *" scenarios. To add something new, just toss in a new matrix item to that task with a distinct $ALT_NAME value. Then pick that up with a new entry in the runner script case block.

[lsm5]

@lsm5 I'm curious why this is needed. My understanding is GO111MODULE=off is only necessary when using really, really, old versions of golang, no?

hmm, I never bothered to check honestly but I could dig in if necessary on that. FWIW, the default fedora %gobuild definition is:

$ rpm --eval %gobuild

  # https://bugzilla.redhat.com/show_bug.cgi?id=995136#c12
     GO111MODULE=off \
  go build -buildmode pie -compiler gc -tags="rpm_crashtraceback ${BUILDTAGS:-}" -ldflags "${LDFLAGS:-} -B 0x$(head -c20 /dev/urandom|od -An -tx1|tr -d ' \n') -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld  '" -a -v -x ;

so I'm guessing there hasn't been any change on newer versions.

CI test-job wise, this sounds like something ripe for inclusion in alt_build_task. This is a kind of catch-all for "Confirm building works in *" scenarios. To add something new, just toss in a new matrix item to that task with a distinct $ALT_NAME value. Then pick that up with a new entry in the runner script case block.

So, given that the spec file is only used for checking if rpm builds fine, I changed the spec file directly without a specific CI job. Things should hopefully be changing very soon when we have the packit integration in place.

[lsm5]

@cevich oh also, if we don't have GO111MODULE=off it ends up fetching all the vendored dependencies which is a no-go for non-networked koji buiilds.

[cevich]

https://bugzilla.redhat.com/show_bug.cgi?id=995136

That BZ is from 2016.

if we don't have GO111MODULE=off it ends up fetching all the vendored dependencies which is a no-go for non-networked koji buiilds.

Oh...right, yeah, golang really wants to be connected to the internet 😞

[cevich]

Things should hopefully be changing very soon when we have the packit integration in place.

Oh okay, yeah, feel free to replace that RPM-build job then. My understand is it's mainly there for package release benefit - noticing problems early. So if there's a better way to do that, go for it.

[lsm5]

ready for lgtm

[mheon]

I think the comment from @rhatdan is addressed
/lgtm

[lsm5]

we also need a /hold cancel i guess.

[rhatdan]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

I thought those were there to indicate where we copied the code from . Perhaps change the import to copied from?

[lsm5]

I thought those were there to indicate where we copied the code from . Perhaps change the import to copied from?

@rhatdan I can give that a try.

[lsm5]

@rhatdan added a comment on top of the package line. I wish golang didn't act funny with comments.

[rhatdan]

/lgtm

[lsm5]

anybody know how to rerun the rdoproject.org/github-check job? It doesn't fail locally for me on centos8

[edsantiago]

rdoproject always fails. We don't care: it doesn't block merging.

[lsm5]

rdoproject always fails. We don't care: it doesn't block merging.

thanks @edsantiago . If someone could please /hold cancel, this should be good for merge.

[lsm5]

/hold cancel