Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network connect should error if netmode is not bridge #9496

Closed
Luap99 opened this issue Feb 23, 2021 · 3 comments · Fixed by #9497
Closed

network connect should error if netmode is not bridge #9496

Luap99 opened this issue Feb 23, 2021 · 3 comments · Fixed by #9497
Assignees
@Luap99
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@Luap99
Copy link
Member

Luap99 commented Feb 23, 2021

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

Containers created with a network mode other than bridge should not work with network connect. (e.g. --network slirp4netns)

Steps to reproduce the issue:

  1. sudo bin/podman run --name test --network slirp4netns -d alpine top

  2. sudo bin/podman network connect cni-podman3 test
    This command actually works and connects to the cni network but does not keep it after a restart. Also inspect is broken with asked to join 2 CNI network(s) [cni-podman3 podman], but have information on 1 network(s)

In my opinion only bridge should be allowed and all other net modes must be rejected by network connect/disconnect.
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 23, 2021
@Luap99 Luap99 self-assigned this Feb 23, 2021
@mheon
Copy link
Member

mheon commented Feb 23, 2021

Concur with disallowing for non-bridge network modes.

@baude
Copy link
Member

baude commented Feb 23, 2021

also agree

Luap99 pushed a commit to Luap99/libpod that referenced this issue Feb 23, 2021
Network connect error if net mode is not bridge
f152f9c 
Only the the network mode bridge supports cni networks.
Other network modes cannot use network connect/disconnect
so we should throw a error.

Fixes containers#9496

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99 Luap99 mentioned this issue Feb 23, 2021
Merged
@Luap99
Copy link
Member Author

Luap99 commented Feb 23, 2021

#9497 to fix

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Luap99 Luap99

Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Network connect error if net mode is not bridge Luap99/libpod
4 participants
@mheon @baude @openshift-ci-robot @Luap99