Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman rm -fa with continers that have --rm should not throw errors #9479

Closed
baude opened this issue Feb 22, 2021 · 3 comments · Fixed by #9485
Closed

podman rm -fa with continers that have --rm should not throw errors #9479

baude opened this issue Feb 22, 2021 · 3 comments · Fixed by #9485
Assignees
@vrothberg
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@baude
Copy link
Member

baude commented Feb 22, 2021 •
edited
Loading

When you have containers that were created with --rm and you perform a rm -fa, there shouldn't be errors thrown that the container is missing (because it is stopped before deletion).

/kind bug

Reproducer:

$ sudo podman run -dt --rm alpine top
$ sudo podman rm -fa

```
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 22, 2021
@baude
Copy link
Member Author

baude commented Feb 22, 2021

I'll grab this if nobody else does.

@vrothberg
Copy link
Member

I'll take a look :^)

@vrothberg vrothberg self-assigned this Feb 23, 2021
vrothberg added a commit to vrothberg/libpod that referenced this issue Feb 23, 2021
@vrothberg
container removal: handle already removed containers
e5ac28f 
Since commit d54478d, a container's lock is released before
attempting to stop it via the OCI runtime.  This opened the window
for various kinds of race conditions.  One of them led to containers#9479 where
the removal+cleanup sequences of a `run --rm` session overlapped with
`rm -af`.  Make both execution paths more robust by handling the case of
an already removed container.

Fixes: containers#9479
Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg vrothberg mentioned this issue Feb 23, 2021
Merged
@vrothberg
Copy link
Member

#9485

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vrothberg vrothberg

Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

container removal: handle already removed containers vrothberg/libpod
3 participants
@baude @vrothberg @openshift-ci-robot