Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: pod stats is not supported in rootless mode without cgroups v2 #8734

Closed
cevich opened this issue Dec 15, 2020 · 4 comments · Fixed by #8983
Closed

Error: pod stats is not supported in rootless mode without cgroups v2 #8734

cevich opened this issue Dec 15, 2020 · 4 comments · Fixed by #8983
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@cevich
Copy link
Member

cevich commented Dec 15, 2020

/kind bug

Description

Nearly/all podman pod stats tests fail when running as a user, on a host using CGroupsV1 & runc-1.0.0-146.rc92. The tests were globally skipped in the case of rootless + CGroupsV2. However, apparently they also cannot function with CGv1 either.

As of #8312 this has been addressed by a blanket SkipIfRootless(). I am not certain if this is otherwise fixable or worth the effort, since --cgroup-manager=cgroupfs is required for rootless operation.

Steps to reproduce the issue:

  1. Execute integration tests as a regular user

Describe the results you received:

(typical failure example)

[+0284s] Podman pod stats 
[+0284s]   podman stats should run with no pods
[+0284s]   /var/tmp/go/src/github.com/containers/podman/test/e2e/pod_stats_test.go:42
[+0284s] 
[+0284s] [BeforeEach] Podman pod stats
[+0284s]   /var/tmp/go/src/github.com/containers/podman/test/e2e/pod_stats_test.go:19
[+0284s] [It] podman stats should run with no pods
[+0284s]   /var/tmp/go/src/github.com/containers/podman/test/e2e/pod_stats_test.go:42
[+0284s] Running: podman --storage-opt vfs.imagestore=/tmp/podman/imagecachedir --root /tmp/.../crio --runroot /tmp/.../crio-run --runtime runc --conmon /usr/bin/conmon --cni-config-dir /home/some20681dude/.config/cni/net.d --cgroup-manager cgroupfs --tmpdir /tmp/... --events-backend file --storage-driver vfs pod stats --no-stream
[+0284s] Error: pod stats is not supported in rootless mode without cgroups v2

Describe the results you expected:

Someone who knows more than me should examine BeforeEach() in test/e2e/pod_stats_test.go to ensure the skip-selection is correct. Esp. after #8312 is merged.

@mheon
Copy link
Member

mheon commented Dec 15, 2020

The logic here sounds inverted. The tests should run on Cgroups v2 + rootless. They are not expected to work on cgroups v1 + rootless.

@cevich
Copy link
Member Author

cevich commented Dec 15, 2020

Sorry, I don't follow how that's any different from the issue title?

@cevich
Copy link
Member Author

cevich commented Dec 15, 2020

Also...aren't you suppose to be on PTO? 😛

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

rhatdan added a commit to rhatdan/podman that referenced this issue Jan 15, 2021
These tests should only be blocked for cgroups V1

Fixes: containers#8734
Signed-off-by: Daniel J Walsh <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants