Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remote is verbosier than local #8343

Closed
edsantiago opened this issue Nov 14, 2020 · 8 comments
Closed

build: remote is verbosier than local #8343

edsantiago opened this issue Nov 14, 2020 · 8 comments
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote stale-issue

Comments

@edsantiago
Copy link
Member

edsantiago commented Nov 14, 2020

An unexpected (to me) difference in output between podman and podman-remote:

$ printf "FROM alpine\nRUN true\n" | bin/podman-remote build -t foo -

Output below is podman(left), podman-remote (right)

STEP 1: FROM alpine         = STEP 1: FROM alpine
STEP 2: RUN true            = STEP 2: RUN true
STEP 3: COMMIT foo          = STEP 3: COMMIT foo
                            > Getting image source signatures
                            > Copying blob sha256:<sha1...>
                            > Copying blob sha256:<sha2...>
                            > Copying config sha256:<sha3...>
                            > Writing manifest to image destination
                            > Storing signatures
--> <sha11>                 = --> <different sha of course>
<sha64>                     = <another sha64>

It's probably not a big deal, and I'm OK with closing this as NOTABUG. I'm just curious if I should adapt my tests to work around this.

master @ 4eb9c28

If this is fixed, please update test:

# FIXME: podman-remote output differs from local: #8342 (spurious ^M)
# FIXME: podman-remote output differs from local: #8343 (extra SHA output)
remote_extra=""
if is_remote; then remote_extra=".*";fi
expect="${random1}
.*
STEP 1: FROM $IMAGE
STEP 2: RUN echo x${random2}y
x${random2}y${remote_extra}
STEP 3: COMMIT build_test${remote_extra}

@edsantiago edsantiago added the remote Problem is in podman-remote label Nov 14, 2020
edsantiago added a commit to edsantiago/libpod that referenced this issue Nov 14, 2020
- images: confirm that 'podman images' emits headings
  even if there are no images present. Intended to
  replace e2e test which is difficult to get working
  under podman-remote.

- build: add test for containers#8092, podman-build gobbling stdin.
  Workaround needed for issues containers#8342 and containers#8343, in which
  podman-remote output differs from podman local.

- volumes: add test for containers#8307, double-lock on same volume.

Signed-off-by: Ed Santiago <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Nov 15, 2020

buildah bud works like podman remote.
They should be consistent,

./bin/buildah bud /tmp
STEP 1: FROM alpine
STEP 2: RUN true
STEP 3: COMMIT
Getting image source signatures
Copying blob ace0eda3e3be skipped: already exists  
Copying blob bf839c0000a1 done  
Copying config 37b38535e9 done  
Writing manifest to image destination
Storing signatures
--> 37b38535e90
37b38535e90b1c51cdf0188bd46c744b358c546925906906dfc6e8a440dc7b54

@nalind WDYT?

@rhatdan
Copy link
Member

rhatdan commented Nov 15, 2020

@edsantiago I don't have easy access to Docker, could you see if Docker puts out this information about blobs?

@edsantiago
Copy link
Member Author

Unfortunately it seems I no longer have a way to run docker either. Something has changed in the year or so since I last tried to set up RHEL subscriptions; it doesn't work any more. I've wasted an hour of my Sunday morning on it, giving up now. Will try again on Monday.

@nalind
Copy link
Member

nalind commented Nov 16, 2020

I think that output is written to the ReportWriter that's passed in BuildOptions. If that option is set differently for remote and local builds, that would explain what you're seeing, and I think that'd be considered a bug.

@rhatdan
Copy link
Member

rhatdan commented Nov 17, 2020

You get the output when --layers=false

@rhatdan
Copy link
Member

rhatdan commented Nov 17, 2020

$ buildah bud --layers=true /tmp/
STEP 1: FROM alpine
STEP 2: RUN echo hello
--> Using cache 4de98db25baab655473e99941cb0980c2dbc89c8949906f09acdaf5ca23fb7b8
--> 4de98db25ba
STEP 3: RUN echo goodbye
--> Using cache 168452bf51ea00e7f56b6ab7dd667309fa6e6b599914e579c29ccb1535d7999a
--> 168452bf51e
STEP 4: RUN echo test2
test2
STEP 5: COMMIT
--> 74812aff1e2
74812aff1e268021cdd606dd9139f42bb4fc1dd02ac924e9c7a23f65ad98f72d
$ buildah bud --layers=false /tmp/
STEP 1: FROM alpine
STEP 2: RUN echo hello
hello
STEP 3: RUN echo goodbye
goodbye
STEP 4: RUN echo test2
test2
STEP 5: COMMIT
Getting image source signatures
Copying blob ace0eda3e3be skipped: already exists  
Copying blob 068908bfdfbf done  
Copying config d112db3949 done  
Writing manifest to image destination
Storing signatures
--> d112db39494
d112db39494d83c00a064a783e9496d25b492439dba0bfc29c06c5413ace10b6

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Dec 18, 2020

I don't think this is a bug, it is just caused by cached images. Closing.

@rhatdan rhatdan closed this as completed Dec 18, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote stale-issue
Projects
None yet
Development

No branches or pull requests

3 participants