Error message needed when creating container in pod with -p option #7373
Assignees
Labels
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
Comments
Luap99
pushed a commit
to Luap99/libpod
that referenced
this issue
Aug 20, 2020
Fixes: 4c75fe3 ("fix pod creation with "new:" syntax") Commit 4c75fe3 passes all net options to the pod but forgot to unset the options for the container creation. This leads to erros when using flags like `--ip` since we tried setting the ip on the pod and container which obviously fails. I didn't notice the bug because we don't throw an error when specifing port bindings on a container which joins the pods network namespace. (containers#7373) Also allow the use of `--hostname` and pass that option to the pod and unset it for the container. The container has to use the pods hostname anyway. This would error otherwise. Added tests to prevent regression. Signed-off-by: Paul Holzinger <[email protected]>
mheon
pushed a commit
to mheon/libpod
that referenced
this issue
Aug 20, 2020
Fixes: 4c75fe3 ("fix pod creation with "new:" syntax") Commit 4c75fe3 passes all net options to the pod but forgot to unset the options for the container creation. This leads to erros when using flags like `--ip` since we tried setting the ip on the pod and container which obviously fails. I didn't notice the bug because we don't throw an error when specifing port bindings on a container which joins the pods network namespace. (containers#7373) Also allow the use of `--hostname` and pass that option to the pod and unset it for the container. The container has to use the pods hostname anyway. This would error otherwise. Added tests to prevent regression. Signed-off-by: Paul Holzinger <[email protected]>
|
Closing since this got already fixed by #7390 |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Pulling this from a discussion by @Luap99 in #7364
IMO, we have to error on the podman create command. I've seen some people run into it and not realize the error.
This should not work:
The create command should note the -p option when being used in a pod and at the very least issue a warning if not an error and disallow it totally.
The text was updated successfully, but these errors were encountered: