Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman-remote: server: superfluous response.WriteHeader call #7197

Closed
edsantiago opened this issue Aug 3, 2020 · 0 comments · Fixed by #7204
Closed

podman-remote: server: superfluous response.WriteHeader call #7197

edsantiago opened this issue Aug 3, 2020 · 0 comments · Fixed by #7204
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote

Comments

@edsantiago
Copy link
Member

Bad response in server when client runs 'container exists nonesuch'.

In window 1:

$ ./bin/podman system service --timeout=0

In window 2:

$ ./bin/podman-remote container exists NoSuchContainer    <-- correctly exits with status 1

Back to window 1:

http: superfluous response.WriteHeader call from github.com/containers/podman/v2/pkg/api/handlers/utils.WriteJSON (handler.go:150)
@edsantiago edsantiago added kind/bug Categorizes issue or PR as related to a bug. remote Problem is in podman-remote labels Aug 3, 2020
baude added a commit to baude/podman that referenced this issue Aug 3, 2020
@baude
Missing return after early exit
ab77487 
the exists code was plagued by a missing return statement meant to trigger an early exit.

Fixes: containers#7197

Signed-off-by: Brent Baude <[email protected]>
@baude baude mentioned this issue Aug 3, 2020
Merged
vrothberg pushed a commit to vrothberg/libpod that referenced this issue Aug 11, 2020
@baude @vrothberg
Missing return after early exit
2ff8f48 
the exists code was plagued by a missing return statement meant to trigger an early exit.

Fixes: containers#7197

Signed-off-by: Brent Baude <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Missing return after early exit baude/podman
1 participant
@edsantiago