Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop [Install] section from podman.service #7190

Closed
martinpitt opened this issue Aug 3, 2020 · 1 comment · Fixed by #7193
Closed

Drop [Install] section from podman.service #7190

martinpitt opened this issue Aug 3, 2020 · 1 comment · Fixed by #7193
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@martinpitt
Copy link
Contributor

/kind bug

/kind feature

Description

podman.service is socket activated through podman.socket. It should not have its own [Install] section, it does not make sense to systemctl enable podman.service. This is defined here.

This leads to podman.service always running on a Debian system, as Debian's policy is to enable/start running services by default.

Can you please drop this?

Output of podman version:

podman version 2.0.4

Package info (e.g. output of rpm -q podman or apt list podman):

podman/unstable,now 2.0.4+dfsg1-1 amd64 [installed]
@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 3, 2020
martinpitt added a commit to martinpitt/cockpit-podman that referenced this issue Aug 3, 2020
2.0.3 breaks API:

 - https://bugs.debian.org/966501
 - containers/podman#7078

The Debian package now ships the REST systemd units, but due to
containers/podman#7190 they get
"over-enabled". Hack around that.
martinpitt added a commit to martinpitt/cockpit-podman that referenced this issue Aug 3, 2020
2.0.3 breaks API:

 - https://bugs.debian.org/966501
 - containers/podman#7078

The Debian package now ships the REST systemd units, but due to
containers/podman#7190 they get
"over-enabled". Hack around that.
marusak pushed a commit to cockpit-project/cockpit-podman that referenced this issue Aug 3, 2020
2.0.3 breaks API:

 - https://bugs.debian.org/966501
 - containers/podman#7078

The Debian package now ships the REST systemd units, but due to
containers/podman#7190 they get
"over-enabled". Hack around that.
@vrothberg
Copy link
Member

Thanks for the report. I'll open a PR in a minute.

vrothberg added a commit to vrothberg/libpod that referenced this issue Aug 3, 2020
podman.service is socket activated through podman.socket. It should not
have its own [Install] section, it does not make sense to systemctl
enable podman.service.

This leads to podman.service always running on a Debian system, as
Debian's policy is to enable/start running services by default.

We don't want a daemon :^)

Fixes: containers#7190
Reported-by: @martinpitt
Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg added a commit to vrothberg/libpod that referenced this issue Aug 11, 2020
podman.service is socket activated through podman.socket. It should not
have its own [Install] section, it does not make sense to systemctl
enable podman.service.

This leads to podman.service always running on a Debian system, as
Debian's policy is to enable/start running services by default.

We don't want a daemon :^)

Fixes: containers#7190
Reported-by: @martinpitt
Signed-off-by: Valentin Rothberg <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants