Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] add manifest subcommand #713

Closed
vbatts opened this issue May 2, 2018 · 34 comments
Closed

[RFE] add manifest subcommand #713

vbatts opened this issue May 2, 2018 · 34 comments
Assignees
Labels
do-not-close locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue

Comments

@vbatts
Copy link
Collaborator

vbatts commented May 2, 2018

https://docs.docker.com/edge/engine/reference/commandline/manifest/

mostly for multi-arch images, but nothing is stopping this from being a way to map arbitrary mime-type objects to be pushing as opaque blobs to the registry as well and be included in the signed image.

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

Description

Steps to reproduce the issue:

Describe the results you received:

Describe the results you expected:

Additional information you deem important (e.g. issue happens only occasionally):

Output of podman version:

(paste your output here)

Output of podman info:

(paste your output here)

Additional environment details (AWS, VirtualBox, physical, etc.):

@mheon
Copy link
Member

mheon commented May 2, 2018

Does containers/image have support for this yet?

@rhatdan
Copy link
Member

rhatdan commented May 2, 2018

@mtrmac indicated that it did, I believe.

@mtrmac
Copy link
Collaborator

mtrmac commented May 7, 2018

c/image does not really support arbitrary opaque blobs, it recognizes layers and config. Adding opaque blobs is plausible, if needed.

As for manifest lists, right now they are only read; writing and converting them is WIP in containers/image#400 . Thec/image/manifest.List abstraction added in that PR could be easily extended for other read or edit operations.

@rhatdan
Copy link
Member

rhatdan commented Jun 4, 2018

@umohnani8 Could you take a look at this?

@rhatdan
Copy link
Member

rhatdan commented Jul 12, 2018

@mtrmac Is this something you could add to podman?

@thomasmckay
Copy link

Bumping this for visibility. Need the equivalent of docker manifest https://docs.docker.com/edge/engine/reference/commandline/manifest/

@baude
Copy link
Member

baude commented Nov 7, 2018

... for ? help us understand and prioritize the use case

@thomasmckay
Copy link

My company's internal tooling builds multiarch images and then makes them available through our registry to customers. Relying on docker commands is not ideal and our tooling is moving away to only use podman/skopeo/buildah.

@rhatdan
Copy link
Member

rhatdan commented Nov 8, 2018

@mtrmac PTAL

@rhatdan
Copy link
Member

rhatdan commented Dec 22, 2018

@mtrmac Any comment? @vbatts Is this still something you want?

@mtrmac
Copy link
Collaborator

mtrmac commented Jan 2, 2019

@mtrmac Any comment?

Not really; we do need something to create multi-arch images, but I obviously haven’t been working on it yet.

@vbatts
Copy link
Collaborator Author

vbatts commented Jan 2, 2019

this would be not only for multi-arch. The use-case here is for additional metadata (e.g. a SWID manifest or gomtree output) to be attached to the image when pushed.

@umohnani8 umohnani8 assigned vrothberg and unassigned umohnani8 Feb 4, 2019
@cgwalters
Copy link
Contributor

This would be very useful for us in building Red Hat CoreOS; see openshift/origin#21998 (comment)

@rhatdan
Copy link
Member

rhatdan commented Mar 8, 2019

@vrothberg @mtrmac Lots of interest in this. Need to bump up the Importance.

@vbatts
Copy link
Collaborator Author

vbatts commented Mar 8, 2019 via email

@rhatdan
Copy link
Member

rhatdan commented Apr 13, 2019

Progress seems to have stalled on this.

@vrothberg
Copy link
Member

Need to bump up the Importance.

Something we can check maybe next sprint? As long as more things are added to the todo, it will be tough to start working on it. In any case, we need containers/image#608 before.

@konrad-ohms
Copy link

Maybe having a look into https://github.com/estesp/manifest-tool could help?
For now someone can use it directly, e.g. in combination with buildah or podman.
If I remember correctly, that project was started before docker got the manifest command, but it works perfectly find also without docker, I use that on a regular basis.

@rhatdan
Copy link
Member

rhatdan commented Apr 15, 2019

If only we could convince @estesp to contribute to libpod. :^)

@fatherlinux
Copy link
Contributor

@mtrmac @vbatts @rhatdan this would also be useful to verify images in the Red Hat registry. For example, the other day, somebody told me there is no UBI for ARM. It's hard to verify if the right multi-arch images were pushed without this sub-command in podman. Also, it could be useful for pushing other artifacts into the registry, per our recent discussions.

@fatherlinux
Copy link
Contributor

@rhatdan
Copy link
Member

rhatdan commented Aug 5, 2019

This came up in a meeting today, and should move up the priority list to at least get better support in contianers/image and containers/storage.

@rhatdan
Copy link
Member

rhatdan commented Aug 10, 2019

I believe @nalind is also working on this?

@github-actions
Copy link

github-actions bot commented Nov 5, 2019

This issue had no activity for 30 days. In the absence of activity or the "do-not-close" label, the issue will be automatically closed within 7 days.

@rhatdan
Copy link
Member

rhatdan commented Nov 5, 2019

@nalind Added support for Buildah, need someone to copy that support into Podman.

@raukadah
Copy link
Contributor

@nalind @rhatdan you are working on this? If not, I want to work on this?

@rhatdan
Copy link
Member

rhatdan commented Dec 18, 2019

@raukadah Go for it.

@vrothberg
Copy link
Member

Friendly ping. Any updates on this?

@vrothberg vrothberg removed their assignment Jan 31, 2020
@raukadah
Copy link
Contributor

raukadah commented Feb 3, 2020

@vrothberg Sorry the late reply, I have started working on that, I will get the PR up by this week.

@rhatdan
Copy link
Member

rhatdan commented Feb 18, 2020

@raukadah Any progress?

@zvonkok
Copy link

zvonkok commented Feb 19, 2020

/cc @zvonkok @sjug

@raukadah
Copy link
Contributor

@rhatdan I did not made any progress, got busy with other works, Please take over this issue. Thanks!

@pothos
Copy link

pothos commented Jun 4, 2020

Just a thought: Would it be a viable workaround to somehow detect the manifest command in the https://github.com/containers/libpod/blob/master/docker wrapper script and run buildah instead of podman?

@vrothberg
Copy link
Member

Happy to share that podman manifest exists. Look forward to Podman v2 🎂

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do-not-close locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue
Projects
None yet
Development

No branches or pull requests