Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman-remote: run docker-archive: ... must be a docker reference #7116

Closed
edsantiago opened this issue Jul 28, 2020 · 6 comments · Fixed by #8465
Closed

podman-remote: run docker-archive: ... must be a docker reference #7116

edsantiago opened this issue Jul 28, 2020 · 6 comments · Fixed by #8465
Labels
HTTP API Bug is in RESTful API kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote stale-issue

Comments

@edsantiago
Copy link
Member

In window 1:

$ ./bin/podman system service --timeout=0

In window 2:

$ ./bin/podman save -o /tmp/alpine.tar alpine
$ ./bin/podman-remote run docker-archive:/tmp/alpine.tar date
Error: image destination "docker-archive:/tmp/alpine.tar" is not a docker-transport reference: reference "docker-archive:/tmp/alpine.tar" must be a docker reference

Expected:

$  ./bin/podman run docker-archive:/tmp/alpine.tar date
Getting image source signatures
Copying blob 50644c29ef5a [--------------------------------------] 0.0b / 0.0b
Copying config a24bb40132 done
Writing manifest to image destination
Storing signatures
Tue Jul 28 17:04:58 UTC 2020

master @ 288ebec , root & rootless

@mheon mheon added HTTP API Bug is in RESTful API kind/bug Categorizes issue or PR as related to a bug. remote Problem is in podman-remote labels Jul 28, 2020
@baude
Copy link
Member

baude commented Aug 6, 2020

@edsantiago this error is actually correct. it may not be clear enough, but it is correct. I'm worried that trying to catch this in the remote client (as opposed to the API), will bloat the remote client by bring in containers/image stuff.

wdyt?

@rhatdan
Copy link
Member

rhatdan commented Aug 7, 2020

So podman-remote run only supports docker transports while podman run supports all of the transports.
We need to document this.

@edsantiago
Copy link
Member Author

@baude I'm totally fine with podman-remote not accepting this usage; I just think the error message may not be helpful to users. Loath as I am to suggest this, could the remote client be hacked to intercept the message and make it palatable? Maybe add a suggestion like "You need to podman load %s first"?

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Nov 24, 2020

@edsantiago if we remove the stutter, does the message become more clear?

./bin/podman-remote run docker-archive:/tmp/alpine.tar date
Error: reference "docker-archive:/tmp/alpine.tar" must be a docker reference

rhatdan added a commit to rhatdan/podman that referenced this issue Nov 29, 2020
The goal is to improve errors when users use the wrong transport
in certain cases we stutter, in other cases we don't give enough
information.

Remove stutters when failing to pull remote images, because of
lack of support.

Fix errors returned by reference.Parse to wrap in image that was being
checked.

Fixes: containers#7116

Signed-off-by: Daniel J Walsh <[email protected]>
@edsantiago
Copy link
Member Author

TBH no, not really. It doesn't help me, the end user, figure out what's wrong. Would it be possible to intercept this error and offer a suggestion?

  • "podman-remote cannot run (or create) a tarball; you need to 'podman-remote load' it first"
  • "podman-remote cannot run/create an OCI archive; please 'podman-remote pull' it first"

...or something along those lines, assuming that one of those would work

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
HTTP API Bug is in RESTful API kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote stale-issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants