Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(podman image sign) uses an unpredictable image name for the destination file #6994

Closed
mtrmac opened this issue Jul 15, 2020 · 1 comment · Fixed by #7081
Closed

(podman image sign) uses an unpredictable image name for the destination file #6994

mtrmac opened this issue Jul 15, 2020 · 1 comment · Fixed by #7081
Assignees
@QiWang19
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@mtrmac
Copy link
Collaborator

mtrmac commented Jul 15, 2020

/kind bug

Description

For now, filling primarily to have a place to track this.

If a specific image is available locally, using several different repo@digest values, podman image sign will use that value instead of the name the user specified for storing the resulting signature.

podman/pkg/domain/infra/abi/images.go

Line 637 in 54d16f3

repos, err := newImage.RepoDigests()
(or the equivalent in earlier versions) should instead use the repository from srcRef and the digest of getManifest, like c/image/docker.{configuredSignatureStorageBase,signatureStorageURL} .
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 15, 2020
@rhatdan
Copy link
Member

rhatdan commented Jul 16, 2020

@QiWang19 PTAL

@QiWang19 QiWang19 mentioned this issue Jul 24, 2020
Merged
@QiWang19 QiWang19 mentioned this issue Aug 3, 2020
Closed
QiWang19 added a commit to QiWang19/podman that referenced this issue Aug 4, 2020
@QiWang19
fix bug podman sign storage path
69ac054 
- fix the bud podman not using specified --directory as signature storage.
- use manifest and image referce to set repo@digest.
close containers#6994
close containers#6993

Signed-off-by: Qi Wang <[email protected]>
vrothberg pushed a commit to vrothberg/libpod that referenced this issue Aug 11, 2020
@QiWang19 @vrothberg
fix bug podman sign storage path
a53b97b 
- fix the bud podman not using specified --directory as signature storage.
- use manifest and image referce to set repo@digest.
close containers#6994
close containers#6993

Backported-by: Valentin Rothberg <[email protected]>
Signed-off-by: Qi Wang <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@QiWang19 QiWang19

Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix bug podman sign storage path QiWang19/podman
4 participants
@rhatdan @mtrmac @QiWang19 @openshift-ci-robot