Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman run image-committed-without-a-name : panic #587

Closed
edsantiago opened this issue Apr 3, 2018 · 1 comment
Closed

podman run image-committed-without-a-name : panic #587

edsantiago opened this issue Apr 3, 2018 · 1 comment
Assignees
@baude
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

I don't know if this is a problem in run or in commit.

# podman run --name foo fedora date
Apr  3 15:05:07 UTC 2018
# cid=$(podman commit --quiet foo)
# podman run $cid                          
panic: runtime error: index out of range                          

goroutine 1 [running]:           
main.runCmd(0xc4200b6f20, 0x0, 0x0)                               
        /builddir/build/BUILD/libpod-db6bf9e3ad7900f0bf062fd12b80706c1bd7bb5f/_build/src/github.com/projectatomic/libpod/cmd/podman/run.go:68 +0x1d06                
github.com/projectatomic/libpod/vendor/github.com/urfave/cli.HandleAction(0xfa3400, 0x119e868, 0xc4200b6f20, 0x0, 0xc4200651a0)     
        /builddir/build/BUILD/libpod-db6bf9e3ad7900f0bf062fd12b80706c1bd7bb5f/_build/src/github.com/projectatomic/libpod/vendor/github.com/urfave/cli/app.go:501 +0xd2                                
github.com/projectatomic/libpod/vendor/github.com/urfave/cli.Command.Run(0x11244b1, 0x3, 0x0, 0x0, 0x0, 0x0, 0x0, 0x1143be6, 0x20, 0x0, ...)                         
        /builddir/build/BUILD/libpod-db6bf9e3ad7900f0bf062fd12b80706c1bd7bb5f/_build/src/github.com/projectatomic/libpod/vendor/github.com/urfave/cli/command.go:165 +0x505                           
github.com/projectatomic/libpod/vendor/github.com/urfave/cli.(*App).Run(0xc4200dca80, 0xc420010090, 0x3, 0x3, 0x0, 0x0)             
        /builddir/build/BUILD/libpod-db6bf9e3ad7900f0bf062fd12b80706c1bd7bb5f/_build/src/github.com/projectatomic/libpod/vendor/github.com/urfave/cli/app.go:259 +0x740                               
main.main()                      
        /builddir/build/BUILD/libpod-db6bf9e3ad7900f0bf062fd12b80706c1bd7bb5f/_build/src/github.com/projectatomic/libpod/cmd/podman/main.go:156 +0x11e3

Feeding it an image name (podman commit --quiet foo bar) eliminates this, but see #586 for a separate problem.

podman-0.3.5-1.gitdb6bf9e.fc27.x86_64
@mheon
Copy link
Member

mheon commented Apr 3, 2018

That's an index out of range in podman run, so we have at a minimum a bug in run. There could also be a bug in commit (outputting bad IDs?) to trigger that bug in run.

@baude baude self-assigned this Apr 3, 2018
@baude baude mentioned this issue Apr 4, 2018
Closed
baude added a commit to baude/podman that referenced this issue Apr 4, 2018
@baude
Run images with no names

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
3dfdf6e 
When an image name has no reponames, you should still be able to run it
by ID.  When doing so, imageName needs to be set to "" so we don't hit an index
out of range error

Resolves: containers#587

Signed-off-by: baude <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@baude baude

Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@edsantiago @mheon @baude