Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honour network settings in podman play/generate kube #5609

Closed
cfelder opened this issue Mar 25, 2020 · 1 comment
Closed

Honour network settings in podman play/generate kube #5609

cfelder opened this issue Mar 25, 2020 · 1 comment
Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@cfelder
Copy link
Contributor

cfelder commented Mar 25, 2020

/kind feature

Description

I am uncertain whether the kube yaml standard supports network settings.

Either podman play kube should honour network settings, e.g. --network or the generated yaml file using podman generate kube should take into account network settings for pods and/or containers.

As far as I can see in #5241 network opts have been added to podman pod create but there seems to be nothing for either podman play kube nor podman generate kube.

For single containers and systemd generation this is already supported using
podman generate systemd {ctrID} --new

Thanks a lot for this.

I checked versions 1.6.4 (CentOS 8), 1.8.0 (Fedora 30) and 1.8.2 (Kubic Repos for CentOS 8)
@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 25, 2020
@rhatdan rhatdan added the Good First Issue This issue would be a good issue for a first time contributor to undertake. label Mar 25, 2020
@rhatdan
Copy link
Member

rhatdan commented Mar 25, 2020

Interested in opening a PR to fix?

snj33v pushed a commit to snj33v/libpod that referenced this issue May 31, 2020
@cfelder @snj33v
Add support for specifying CNI networks in podman play kube
f35ce3a 
Fixes: containers#5609
Signed-off-by: Christian Felder <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rhatdan @cfelder @openshift-ci-robot