Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile tab completion turned very slow #4829

Closed
vrothberg opened this issue Jan 10, 2020 · 0 comments · Fixed by #5017
Closed

Makefile tab completion turned very slow #4829

vrothberg opened this issue Jan 10, 2020 · 0 comments · Fixed by #5017
Assignees
@vrothberg
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@vrothberg
Copy link
Member

I commonly use tab completion to list Make targets. This has worked out well for a long time but at some point (didn't bisect yet), the completion started to take veeerrry long.

Although this might not be a big issue I suspect that the Makefile is doing too much work and may need some house cleaning.
@vrothberg vrothberg mentioned this issue Jan 29, 2020
Merged
vrothberg added a commit to vrothberg/libpod that referenced this issue Jan 30, 2020
@vrothberg
speed up Makefile
4ec893a 
Speed up the Makefile by removing variable references from the release
targets.  Now, the variables will only be (lazily) evaluated when they
are actually needed and not for each invocation of the Makefile which
has it down considerably.

Fixes: containers#4829
Signed-off-by: Valentin Rothberg <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vrothberg vrothberg

Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Makefile cleanups vrothberg/libpod
1 participant
@vrothberg