make lint fails on macos

[ssbarnea]

$ make lint                                                                                                                                                                                                    Makefile:47: Podman is being compiled without the systemd build tag. Install libsystemd on Ubuntu or systemd-devel on rpm based distro for journald support
X11 forwarding request failed
X11 forwarding request failed
GO111MODULE=off go generate ./cmd/podman/varlink/...
../../../vendor/github.com/varlink/go/cmd/varlink-go-interface-generator/main.go:12:2: cannot find package "github.com/varlink/go/varlink/idl" in any of:
/usr/local/Cellar/go/1.13.4/libexec/src/github.com/varlink/go/varlink/idl (from $GOROOT)
/Users/ssbarnea/go/src/github.com/varlink/go/varlink/idl (from $GOPATH)
cmd/podman/varlink/generate.go:3: running "go": exit status 1
make: *** [cmd/podman/varlink/iopodman.go] Error 1
FAIL: 2

[rhatdan]

@baude PTAL

[baude]

We dont support native compilation on osx ... only cross-compile from linux. Varlink is one reason. @ssbarnea how do you want to deal with this/go from here.

[ssbarnea]

Linting must work from any platform likely to support contributions from, even if compilation would be cross-compiled.

I was planning to do something about it myself but got busy with other stuff. Keep it open until someone fixes it.

I would consider acceptable even if only pre-commit runs on macos and the rest is skipped. The more interesting aspect is that pre-commit works but make never reaches it because chokes at the dependency target it cannot build.

If any idea about how to make that target optional for macos it would be great.

PS. In fact make could start some containers and do the build with them for unsupported platforms, but this would require lots of changes.

If you tell me which patch to take, I can look into making a PR to address it.

[medyagh]

@vrothberg this issue seem to still exist !
on mac :

==> make podman-remote
Last 15 lines from /Users/medya/Library/Logs/Homebrew/podman/01.make:
make
podman-remote
uname: illegal option -- o
usage: uname [-amnprsv]
mkdir -p "/private/tmp/podman-20200210-97980-183905n/_output/src/github.com/containers"
ln -sfn "/private/tmp/podman-20200210-97980-183905n" "/private/tmp/podman-20200210-97980-183905n/_output/src/github.com/containers/libpod"
ln -sfn "/private/tmp/podman-20200210-97980-183905n/vendor/github.com/varlink" "/private/tmp/podman-20200210-97980-183905n/_output/src/github.com/varlink"
touch .gopathok
GO111MODULE=on go build -mod=vendor  -gcflags 'all=-trimpath=/private/tmp/podman-20200210-97980-183905n' -asmflags 'all=-trimpath=/private/tmp/podman-20200210-97980-183905n' -ldflags '-X github.com/containers/libpod/libpod/define.gitCommit=e57253d06841d7a128ef760f8c47acf4b59157df -X github.com/containers/libpod/libpod/define.buildInfo=1581368899 -X github.com/containers/libpod/libpod/config._installPrefix=/usr/local -X github.com/containers/libpod/libpod/config._etcDir=/etc -extldflags ""' -tags "containers_image_openpgp exclude_graphdriver_btrfs exclude_graphdriver_devicemapper exclude_graphdriver_overlay varlink remoteclient" -o bin/podman-remote github.com/containers/libpod/cmd/podman
# github.com/containers/libpod/cmd/podman/shared
cmd/podman/shared/intermediate_varlink.go:70:42: undefined: iopodman.Create
cmd/podman/shared/intermediate_varlink.go:71:7: undefined: iopodman.Create
cmd/podman/shared/intermediate_varlink.go:317:34: undefined: iopodman.Create
make: *** [bin/podman-remote] Error 2
READ THIS: https://docs.brew.sh/Troubleshooting

[vrothberg]

-> #5162

Thanks for the ping!