Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic on push #4013

Closed
trv-rpeoples opened this issue Sep 12, 2019 · 5 comments · Fixed by #4022
Closed

panic on push #4013

trv-rpeoples opened this issue Sep 12, 2019 · 5 comments · Fixed by #4022
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@trv-rpeoples
Copy link

OS: macOS 10.14.6
Podman version: 1.5.1

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

Trying to push a locally built Docker image to an OpenShift registry

Steps to reproduce the issue:

  1. Build image with docker build -t my-image .

  2. Use oc login to login, oc project <projectname> to set project

  3. podman push my-image my.openshift.registry/my-project/my-image

Describe the results you received:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x50 pc=0x1e30d99]

goroutine 1 [running]:
main.pushCmd(0x31acb00, 0x0, 0x0)
	cmd/podman/push.go:90 +0x1b9
main.glob..func57(0x3189c60, 0xc00000c720, 0x2, 0x2, 0x0, 0x0)
	cmd/podman/push.go:36 +0x86
github.com/spf13/cobra.(*Command).execute(0x3189c60, 0xc0000ba020, 0x2, 0x2, 0x3189c60, 0xc0000ba020)
	vendor/github.com/spf13/cobra/command.go:826 +0x465
github.com/spf13/cobra.(*Command).ExecuteC(0x318b560, 0xc0003b6c90, 0x7ffeefbffae8, 0x6)
	vendor/github.com/spf13/cobra/command.go:914 +0x2fc
github.com/spf13/cobra.(*Command).Execute(...)
	vendor/github.com/spf13/cobra/command.go:864
main.main()
	cmd/podman/main.go:148 +0x88

Describe the results you expected:
A successful push of the image to the registry

Additional information you deem important (e.g. issue happens only occasionally):
Have tried many variations of image name, tag, etc and cannot workaround the issue

Output of podman version:

1.5.1

Output of podman info --debug:

Error: could not get runtime: dial unix /run/podman/io.podman: connect: no such file or directory

Package info (e.g. output of rpm -q podman or apt list podman):

N/A

Additional environment details (AWS, VirtualBox, physical, etc.):
macOS 10.14.6, installed podman via: brew cask install podman

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 12, 2019
@TomSweeneyRedHat
Copy link
Member

@trv-rpeoples thanks for the issue report. If you've the time, can you try two quick tests? First one is remove the '-' from the image name. i.e. "my-image" to "myimage". I think the dash is valid, but am not 100% sure.

Second test, after logging into oc-login, can you do podman login and login to your registry and then try the push again?

@mheon
Copy link
Member

mheon commented Sep 12, 2019

Are you connecting to Podman running in a Linux VM, or attempting to run directly on OS X? The latter is not supported.

@trv-rpeoples
Copy link
Author

@mheon I’m using it directly on OS X. As for that not being supported, I did not see that indicated in the README, the Installation Instructions, or the Troubleshooting Guide. Is that an accurate statement?

@mheon
Copy link
Member

mheon commented Sep 13, 2019

Seems to be. We have an OS X tutorial (https://github.com/containers/libpod/blob/master/mac_client.md), but I can't find a link to it in the main README/tutorial. We'll see about adding that.

@mheon
Copy link
Member

mheon commented Sep 13, 2019

Also, the fact that it's getting far enough to segfault without a connection being made is bad - we need to improve error messaging for the remote client when a connection is unavailable.

baude added a commit to baude/podman that referenced this issue Sep 13, 2019
to prevent client side panics, we should get the runtime earlier in the
process of push.

Fixes: containers#4013

Signed-off-by: baude <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants