Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

race: podman-remote stop --cidfile --ignore does very weird things #23554

Closed
edsantiago opened this issue Aug 8, 2024 · 1 comment · Fixed by #23581
Closed

race: podman-remote stop --cidfile --ignore does very weird things #23554

edsantiago opened this issue Aug 8, 2024 · 1 comment · Fixed by #23581
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote

Comments

@edsantiago
Copy link
Member

I can't find a way to reproduce this actual bug but it is super reproducible in BATS:

<+014ms> # # podman-remote --url unix:///tmp/CI_TVd8/podman_tmp_zsap stop --cidfile=/tmp/CI_TVd8/podman_bats.4OGhmH/no-such-file --ignore
<+9.98s> # 0090f32ea149f1e6ebc63979910c705b82365860d95f8b034848759ee47e3c12
         # Error: no container with name or ID "47158e686535dd8c907085d24b480969c50ddaebc880152c96a9abd0417d51a3" found: no such container

That is: wtfff?

This sort of reproduces it after a long time (1-2 minutes) but still, wtf??

Window 1:

$ podman system service --timeout=0

Window 2:

$ while :;do bin/podman run --rm quay.io/libpod/testimage:20240123 date;done

Window 3:

while :;do bin/podman-remote stop --cidfile /this/does/not/exist --ignore || break;done

Window 3 spits out CID after CID after CID ??? Then, after a while, it finally dies

Error: no container with ID c0c5b067c03004b53fa800938747e6842c0966b5352a8d477ebe1a8ece3b2a0a found in database: no such container
@edsantiago edsantiago added the remote Problem is in podman-remote label Aug 8, 2024
@Luap99
Copy link
Member

Luap99 commented Aug 8, 2024

so when ignore is used the error reading the file will be ignored, then we call into the backend without any containers which should not do anything. This seems to work locally, remote however thinks that means it should stop all containers.

@Luap99 Luap99 added the kind/bug Categorizes issue or PR as related to a bug. label Aug 12, 2024
@Luap99 Luap99 self-assigned this Aug 12, 2024
Luap99 added a commit to Luap99/libpod that referenced this issue Aug 12, 2024
When the client gets a 404 back we know the container does not exists,
if ignore is set as well we should just ignore the error client side.

seen in containers#23554

Signed-off-by: Paul Holzinger <[email protected]>
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Nov 11, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants