Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quadlet: add Container-spec StopSignal mapping to podman --stop-signal #23050

Closed
tsutsu opened this issue Jun 19, 2024 · 2 comments · Fixed by #23354
Closed

quadlet: add Container-spec StopSignal mapping to podman --stop-signal #23050

tsutsu opened this issue Jun 19, 2024 · 2 comments · Fixed by #23354
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. quadlet

Comments

@tsutsu
Copy link

tsutsu commented Jun 19, 2024

Feature request description

Using a quadlet .container unit, I want to set the stop signal for the created container.

(I have a third-party container image for a workload that ignores SIGTERM, instead only responding to SIGINT. The container image was additionally not configured with a STOPSIGNAL when built. So I need to somehow get the container unit to pass --stop-signal to podman run.)

Suggest potential solution

Just as systemd service units have StopSignal in the [Service] section, I would expect quadlet container units to support StopSignal in the [Container] section, translating it to podman --stop-signal.

Have you considered any alternatives?

I am currently using PodmanArgs=--stop-signal=SIGINT to pass the flag directly. (But it took me sleeping on the problem to even realize I could do that.)

@tsutsu tsutsu added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 19, 2024
@Luap99 Luap99 added the quadlet label Jun 20, 2024
@ygalblum
Copy link
Contributor

Hi @tsutsu thanks for opening this issue. As you discovered, the PodmanArgs key was added for these exact cases, i.e. when the specific key is not supported.
Care to open a PR to add the support for the StopSignal key?

Copy link

A friendly reminder that this issue had no activity for 30 days.

rhatdan added a commit to rhatdan/podman that referenced this issue Jul 22, 2024
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 21, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. quadlet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants