Hostname written to /etc/hostname does not include new-line at end

[dagraff-cisco]

As noted in docker, the hostname written to /etc/hostname does not include a new-line at the end.

As per debian's hostname (5) man page:

The file should contain a single newline-terminated hostname string. Comments (lines starting with a "#") are ignored. The hostname should be composed of up to 64 7-bit ASCII lower-case alphanumeric characters or hyphens forming a valid DNS domain name. It is recommended that this name contains only a single label, i.e. without any dots. Invalid characters will be filtered out in an attempt to make the name valid, but obviously it is recommended to use a valid name and not rely on this filtering.

The code in question: is here

podman/libpod/container_internal_linux.go

Line 667 in f7a3046

hostnamePath, err := c.writeStringToRundir("hostname", c.Hostname())

This should be amended to read

hostnamePath, err := c.writeStringToRundir("hostname", fmt.Sprintf("%s\n", c.Hostname()))

[raghavgh]

@Luap99 Can i pick this up?

[rhatdan]

You got it.

[ut-wangbo]

@rhatdan
I noticed that this issue has not been closed for two weeks. And I wanna try to make my first contribution for containers/podman . ^_^

[raghavgh]

@rhatdan Apologies I didn't found time from few weeks to complete this task, please help re assign. Thank you

…

On Fri, 31 May 2024, 07:52 Bo Wong, ***@***.***> wrote: @rhatdan <https://github.com/rhatdan> I noticed that this issue has not been closed for two weeks. And I wanna try to make my first contribution for containers/podman . ^_^ — Reply to this email directly, view it on GitHub <#22729 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHWWWWSCNPXRRKFGIPSRPVLZE7NFDAVCNFSM6AAAAABH2XM7BWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBRGEZDINBRHA> . You are receiving this because you were assigned.Message ID: ***@***.***>

[rhatdan]

@ut-wangbo you got it.

[dagraff-cisco]

I have created a branch to address this in a forked repository - if you would like me to proceed with a PR for this please let me know.

[rhatdan]

If you have a fix, please open a PR.

[dagraff-cisco]

This issue was closed in June - however was not included into 5.1 - what is the process to request inclusion?

[Luap99]

It will be part of 5.2 which will be released in the next few weeks.

[dagraff-cisco]

@Luap99 thank you very much for the super fast response. Truly appreciate the work y'all do!