-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support better isulation when building images as part of kube play
#20024
Labels
kind/feature
Categorizes issue or PR as related to a new feature.
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
Comments
ifireball
added
the
kind/feature
Categorizes issue or PR as related to a new feature.
label
Sep 19, 2023
Interested in doing any of this yourself? @flouthoc WDYT? |
Yes I think |
I'll check this. |
A friendly reminder that this issue had no activity for 30 days. |
@flouthoc any update? |
rhatdan
added a commit
to rhatdan/podman
that referenced
this issue
Oct 24, 2023
Users can specify BUILDAH_ISOLATION environment variable to change the default. Fixes: containers#20024 Currently podman play kube is defaulting to chroot, which is the least safe version of build, we should always default to secure whenever possible. Chroot should only be used when building within a container. No great way to tests this. [NO NEW TESTS NEEDED] Signed-off-by: Daniel J Walsh <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
label
Jan 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
kind/feature
Categorizes issue or PR as related to a new feature.
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
Feature request description
podman kube play
has a useful option to build an image when the image specified in the K8s YAML maps to a directory with a Dockerfile or a Container file in it.Currently when images are built this way, the isolation use is hard-coded to "cheroot" as evident by this code.
This can cause more complex container builds to fail due to e.g. collisions with resources running on the host.
Suggest potential solution
I would like to have at least one of the following:
podman build
fail to build withpodman kube play
BUILDAH_ISOLATION
environment variableHave you considered any alternatives?
We are currently telling people to build the images on their own via
podman build
before spinning up their environment viapodman kube play
. We may also end up providing our own wrapper script, but this is cumbersome. We'd really like to have a single command to spin up a work environment.Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: