Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm -fa + dependencies is still issuing warnings #18865

Closed
edsantiago opened this issue Jun 12, 2023 · 2 comments · Fixed by #18971
Closed

rm -fa + dependencies is still issuing warnings #18865

edsantiago opened this issue Jun 12, 2023 · 2 comments · Fixed by #18971
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

I assume it's a flake, since otherwise Matt's PR would never have merged.

[It] podman rm -fa with dependencies
...
# podman [options] rm -fa
kill container: No such process
a56742cb3f318e7bebcf568d2fb67c72e2753528be9df535211c451b3a4a4230
5210226ca965cd1b101ea5c4d417957e84463b53f47d4f228545a5d999ffcb39

[FAILED] rm -fa error logged

In rawhide root

@edsantiago edsantiago added the flakes Flakes from Continuous Integration label Jun 12, 2023
@Luap99
Copy link
Member

Luap99 commented Jun 13, 2023

I cannot find kill container in the podman codebase (only looking at error messages)

However I see that in the crun code right below the open pidfd one. So basically we manage to hit the tiny window between pidfd_open() and then the container exited right after that but before it reads the status from /proc/$pid/stat.
https://github.com/containers/crun/blob/7da99fb998a89e5f258dea67b7387f741808e58d/src/libcrun/linux.c#L5333-L5338

So I would argue we need to match this string as well, @mheon WDYT?

@mheon
Copy link
Member

mheon commented Jun 13, 2023

Now that we've built ourselves a mechanism for catching superfluous errors, we might as well use it. Let's get this error included.

edsantiago added a commit to edsantiago/libpod that referenced this issue Jun 22, 2023
Resolves: containers#18865

[NO NEW TESTS NEEDED] -- it's a flake

Signed-off-by: Ed Santiago <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants