Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quadlet: support for the --hostname parameter #18486

Closed
jklaiho opened this issue May 5, 2023 · 1 comment · Fixed by #18515
Closed

Quadlet: support for the --hostname parameter #18486

jklaiho opened this issue May 5, 2023 · 1 comment · Fixed by #18515
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. quadlet

Comments

@jklaiho
Copy link

jklaiho commented May 5, 2023

Feature request description

Would be nice if a Hostname (HostName?) key was available in the .container generators, corresponding to the --hostname option to podman run. Just another step towards feature parity.

If I had any Go experience at all, I'd send a PR for this myself, but alas.

Suggest potential solution

No response

Have you considered any alternatives?

Of course, this can be done now using PodmanArgs, but its use is not recommended by the documentation.

Additional context

No response
@jklaiho jklaiho added the kind/feature Categorizes issue or PR as related to a new feature. label May 5, 2023
@Luap99 Luap99 added the quadlet label May 8, 2023
@vrothberg
Copy link
Member

Thanks for reaching out, @jklaiho!

I can take this request to keep my hands warm until the next meeting :)

@vrothberg vrothberg mentioned this issue May 9, 2023
Merged
openshift-merge-robot pushed a commit that referenced this issue May 9, 2023
@vrothberg
quadlet: support HostName
b97be34 
Add a new `HostName` field to Quadlet `.container` files.

Fixes: #18486
Signed-off-by: Valentin Rothberg <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. quadlet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

quadlet: support HostName vrothberg/libpod
3 participants
@jklaiho @vrothberg @Luap99