Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman run, with nonexistent $REGISTRY_AUTH_FILE, fails with ENOENT #18405

Closed
edsantiago opened this issue May 1, 2023 · 2 comments · Fixed by #19391
Closed

podman run, with nonexistent $REGISTRY_AUTH_FILE, fails with ENOENT #18405

edsantiago opened this issue May 1, 2023 · 2 comments · Fixed by #19391
Assignees
@Luap99
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member 

$ REGISTRY_AUTH_FILE=/tmp/nonexistent.json bin/podman run quay.io/libpod/testimage:20221018 date
Error: stat /tmp/nonexistent.json: no such file or directory

podman create and info work fine.
@edsantiago edsantiago added the kind/bug Categorizes issue or PR as related to a bug. label May 1, 2023
@Luap99 Luap99 self-assigned this May 2, 2023
Luap99 added a commit to Luap99/libpod that referenced this issue May 2, 2023
@Luap99
podman run --authfile do not stat file
7591f96 
No other commands do this, it makes no sense to fail hard if the given
authfile does not exists. We do not even know if we have to pull
anything at that point. I expect the code to error at some later point
if the auth file is really needed but does not exists.

Fixes containers#18405

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99 Luap99 mentioned this issue May 2, 2023
Closed
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

A friendly reminder that this issue had no activity for 30 days.

@edsantiago
Copy link
Member Author

As of #19348, podman create no longer works as described above:

$ REGISTRY_AUTH_FILE=/tmp/nonexistent bin/podman create quay.io/libpod/testimage:20221018 top
Error: checking authfile: stat /tmp/nonexistent: no such file or directory

I still think this is a bug, so I am leaving this issue open... presumably for someone else to close WONTFIX.

edsantiago added a commit to edsantiago/libpod that referenced this issue Jul 26, 2023
@edsantiago
System tests: missing authfile: also check envariable
f74d257 
Followup to containers#19348 and containers#19374: the new existence check also
works when REGISTRY_AUTH_FILE points to a nonexistent file.
(Except for "podman build"). Add tests.

It is not clear to me that this is desirable behavior (see containers#18405),
but it seems too late to change it.

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago edsantiago mentioned this issue Jul 26, 2023
Closed
@rhatdan rhatdan mentioned this issue Jul 27, 2023
Merged
rhatdan added a commit to rhatdan/podman that referenced this issue Jul 27, 2023
@rhatdan
Make sure users changes --authfile before checking
f540bbf 
In certain cases REGISTRY_AUTH_FILE is set but the auth file
does not exists yet, do not throw error unless user specified
a file directly using --authfile.

Fixes: containers#18405

Signed-off-by: Daniel J Walsh <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Luap99 Luap99

Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
2 participants
@edsantiago @Luap99