Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman machine rm for QEMU provider removed connections before confirmation #18330

Closed
arixmkii opened this issue Apr 24, 2023 · 2 comments · Fixed by #18359
Closed

podman machine rm for QEMU provider removed connections before confirmation #18330

arixmkii opened this issue Apr 24, 2023 · 2 comments · Fixed by #18359
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@arixmkii
Copy link
Contributor

Issue Description

After calling podman machine rm and pressing n to abort, the machine is not functional as connections are erased. Confirmed for QEMU on Windows and macOS.

The code part causing this is https://github.com/containers/podman/blob/main/pkg/machine/qemu/machine.go#L960 which is immediate, but should go inside callback https://github.com/containers/podman/blob/main/pkg/machine/qemu/machine.go#L992 (like in WSL implementation). WSL implementation is not affected.

Steps to reproduce the issue

Steps to reproduce the issue

  1. podman machine init
  2. podman machine rm
  3. press n
  4. podman system connection list (no connections)
  5. podman machine list (machine still exists)

Describe the results you received

Connections are erased.

Describe the results you expected

Connections persisted like in WSL case on Widnows

podman info output

Intentionally skipped as machine was already ruined.

Podman in a container

No

Privileged Or Rootless

None

Upstream Latest Release

Yes

Additional environment details

On Windows was tested with built from latest main + QEMU machine supporting changes on top.

Additional information

No response

@arixmkii arixmkii added the kind/bug Categorizes issue or PR as related to a bug. label Apr 24, 2023
@baude
Copy link
Member

baude commented Apr 24, 2023

this is a legit bug ... if anyone on the team can get to this, it'd be great ... the bug is also in the hyperv implementation.

@Luap99 Luap99 self-assigned this Apr 26, 2023
@Luap99
Copy link
Member

Luap99 commented Apr 26, 2023

@baude I can take it, I see that it is broken in qemu but it looks correct in hyperV.

Luap99 added a commit to Luap99/libpod that referenced this issue Apr 26, 2023
the connection remove call must be done inside the function that is
returned so that we wait until the user confirmed it.

Fixes containers#18330

Signed-off-by: Paul Holzinger <[email protected]>
Luap99 added a commit to Luap99/libpod that referenced this issue May 23, 2023
the connection remove call must be done inside the function that is
returned so that we wait until the user confirmed it.

Fixes containers#18330

Signed-off-by: Paul Holzinger <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants