Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sys] quadlet tests: do not see STARTED CONTAINER #18132

Closed
edsantiago opened this issue Apr 10, 2023 · 1 comment · Fixed by #18144
Closed

[sys] quadlet tests: do not see STARTED CONTAINER #18132

edsantiago opened this issue Apr 10, 2023 · 1 comment · Fixed by #18144
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. quadlet

Comments

@edsantiago
Copy link
Member

Seen only twice:

not ok 335 quadlet - basic
...
# #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
# #|     FAIL: [no test name given]
# #| expected: '.*STARTED CONTAINER.*' (using expr)
# #|   actual: 'Mar 22 09:20:23 cirrus-task-4969608193507328 systemd[3654]: Starting basic_nrdAEkmIB3.service...'
# #|         > 'Mar 22 09:20:23 cirrus-task-4969608193507328 podman[96869]: 2023-03-22 09:20:23.640335349 -0500 CDT m=+0.064749298 container create c300796e7ddffa54c763a6ea9d7eb4883db32e438502ff4f6a2eeb0ee504bc98 (image=quay.io/libpod/testimage:20221018, name=systemd-basic_nrdAEkmIB3, io.buildah.version=1.28.0, PODMAN_SYSTEMD_UNIT=basic_nrdAEkmIB3.service, created_at=2022-10-18T16:28:08Z, created_by=test/system/build-testimage)'
# #|         > 'Mar 22 09:20:23 cirrus-task-4969608193507328 podman[96869]: 2023-03-22 09:20:23.708614665 -0500 CDT m=+0.133028613 container init c300796e7ddffa54c763a6ea9d7eb4883db32e438502ff4f6a2eeb0ee504bc98 (image=quay.io/libpod/testimage:20221018, name=systemd-basic_nrdAEkmIB3, created_by=test/system/build-testimage, io.buildah.version=1.28.0, PODMAN_SYSTEMD_UNIT=basic_nrdAEkmIB3.service, created_at=2022-10-18T16:28:08Z)'
# #|         > 'Mar 22 09:20:23 cirrus-task-4969608193507328 podman[96869]: 2023-03-22 09:20:23.619373694 -0500 CDT m=+0.043787699 image pull f5a99120db6452661930a1db3bf7390eec9b963f5f62c068fa32dc1d550afad3 quay.io/libpod/testimage:20221018'

Probably a race condition in the test.

[sys] quadlet - basic
@edsantiago edsantiago added flakes Flakes from Continuous Integration quadlet labels Apr 10, 2023
@vrothberg vrothberg mentioned this issue Apr 11, 2023
Merged
@vrothberg
Copy link
Member

#18144 should fix it

vrothberg added a commit to vrothberg/libpod that referenced this issue Apr 11, 2023
@vrothberg
test/system/252-quadlet.bats: fix flake
676486a 
Wait for the expected logs to appear in the journal before using
`journalctl`.  containers#18132 is likely flaking because `journalctl` does
not yet see the container's logs.

Also force the test to use the `passthrough` log driver to make sure
`podman logs` continues being tests.

Fixes: containers#18132
Signed-off-by: Valentin Rothberg <[email protected]>
@sstosh sstosh mentioned this issue Jul 14, 2023
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. quadlet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test/system/252-quadlet.bats: fix flake vrothberg/libpod
2 participants
@edsantiago @vrothberg