This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Podman Test Day #17912
Labels
Comments
Luap99
added a commit
to Luap99/libpod
that referenced
this issue
Apr 20, 2023
Commit 1ab833f improved the situation but it is still not enough. If you run short lived containers with --restart=always podman is basically permanently restarting them. To only way to stop this is podman stop. However podman stop does not do anything when the container is already in a not running state. While this makes sense we should still mark the container as explicitly stopped by the user. Together with the change in shouldRestart() which now checks for StoppedByUser this makes sure the cleanup process is not going to start it back up again. A simple reproducer is: ``` podman run --restart=always --name test -d alpine true podman stop test ``` then check if the container is still running, the behavior is very flaky, it took me like 20 podman stop tries before I finally hit the correct window were it was stopped permanently. With this patch it worked on the first try. Fixes containers#18259 [NO NEW TESTS NEEDED] This is super flaky and hard to correctly test in CI. MY ginkgo v2 work seems to trigger this in play kube tests so that should catch at least some regressions. Also this may be something that should be tested at podman test days by users (containers#17912). Signed-off-by: Paul Holzinger <[email protected]>
|
A friendly reminder that this issue had no activity for 30 days. |
|
@sumantro93 what is happening with this issue? Is this something required for Podman? |
Luap99
added a commit
to Luap99/libpod
that referenced
this issue
May 23, 2023
Commit 1ab833f improved the situation but it is still not enough. If you run short lived containers with --restart=always podman is basically permanently restarting them. To only way to stop this is podman stop. However podman stop does not do anything when the container is already in a not running state. While this makes sense we should still mark the container as explicitly stopped by the user. Together with the change in shouldRestart() which now checks for StoppedByUser this makes sure the cleanup process is not going to start it back up again. A simple reproducer is: ``` podman run --restart=always --name test -d alpine true podman stop test ``` then check if the container is still running, the behavior is very flaky, it took me like 20 podman stop tries before I finally hit the correct window were it was stopped permanently. With this patch it worked on the first try. Fixes containers#18259 [NO NEW TESTS NEEDED] This is super flaky and hard to correctly test in CI. MY ginkgo v2 work seems to trigger this in play kube tests so that should catch at least some regressions. Also this may be something that should be tested at podman test days by users (containers#17912). Signed-off-by: Paul Holzinger <[email protected]>
|
A friendly reminder that this issue had no activity for 30 days. |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Hey Folks!
We are in beta now and this is a good time to start planning for a Test Day/Week.
As discussed, we will have this post April 15th ( 2023-04-15)
Initial Tasks (to be done at least one week before test week)
podmanrepoTo be done after the Fedora QA folks have taken action on the QA ticket:
podmanwith TODO items.Announcing Test Week
Should be completed after the Initial Tasks are done
Draft an email to [email protected] and few other relevant announcing the Test Week
podman-issue-trackerfor Test WeekCross-post announcement email to discussion.fedoraproject.org with
#podmantag and whatever fits fineExample format: https://hackmd.io/lCrVoW_RSMCRf2neiGhiPg
During Test Week
podmanissue tracker for new issues reported as part of Test WeekAfter Test Week
podmanticket with any issues foundpodmanissue tracker ticket with any documentation updates madeThe text was updated successfully, but these errors were encountered: