Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUNNING echoed tons of times in gating tests making things hard to read #17675

Closed
lsm5 opened this issue Mar 1, 2023 · 4 comments
Closed

RUNNING echoed tons of times in gating tests making things hard to read #17675

lsm5 opened this issue Mar 1, 2023 · 4 comments
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue

Comments

@lsm5
Copy link
Member

lsm5 commented Mar 1, 2023

SLEEPLOOP='trap "echo BYE;exit 0" INT;echo READY;while :;do echo RUNNING;sleep 0.1;done'

Fedora gating test logs are now hard to read wherever there are failures:

Snippet:

not ok 89 podman sigproxy test: run
# (from function `die' in file ./helpers.bash, line 541,
#  from function `_test_sigproxy' in file ./032-sig-proxy.bats, line 64,
#  in test file ./032-sig-proxy.bats, line 78)
#   `_test_sigproxy c_run $kidpid' failed
# $ /usr/bin/podman rm -t 0 --all --force --ignore
# $ /usr/bin/podman ps --all --external --format {{.ID}} {{.Names}}
# $ /usr/bin/podman images --all --format {{.Repository}}:{{.Tag}} {{.ID}}
# quay.io/libpod/testimage:20221018 f5a99120db64
# $ /usr/bin/podman container exists c_run
# $ /usr/bin/podman logs c_run
# READY
# RUNNING
# RUNNING
# RUNNING
# RUNNING
# RUNNING
# RUNNING
# RUNNING
# RUNNING
# RUNNING
# RUNNING
# RUNNING
# RUNNING
# RUNNING
# RUNNING
# RUNNING
# RUNNING
# $ /usr/bin/podman logs c_run
# READY
# RUNNING
# RUNNING
# RUNNING

See full log at: https://artifacts.dev.testing-farm.io/7c32f881-dfcb-4986-b9ac-1c932509853b/work-tests.yml5g7yl1ij/tests-98utwnvw/test.podman-rootless-cgroupsv2.bats.log

@edsantiago PTAL

@rhatdan
Copy link
Member

rhatdan commented Mar 1, 2023

Just remove the echo. Looks like debug.

@edsantiago
Copy link
Member

Actually that looks like super useful info. It tells me the container is running and things are happening, so it's not a problem with the container itself not running. It suggests a problem with the signal handling. I'm on PTO, ain't gonna look for another 9-10 days or so, but this is good stuff to know. Thanks. (@rhatdan it technically is debug, but this is precisely the situation that calls for that kind of debug)

@github-actions
Copy link

github-actions bot commented Apr 1, 2023

A friendly reminder that this issue had no activity for 30 days.

@lsm5
Copy link
Member Author

lsm5 commented Apr 3, 2023

i'm ok with closing this. I can grep for not ok in the test logs and ignore all the RUNNING lines

@lsm5 lsm5 closed this as completed Apr 3, 2023
edsantiago added a commit to edsantiago/libpod that referenced this issue Apr 3, 2023
One of our oldest most frustrating flakes is containers#16091, "Timed
out waiting for BYE".

In containers#17489 we added some debug output to see if the problem
was a container hang of some sort. It does not seem to be
(see containers#17675), and the debug output makes it hard to read
failure logs, so let's remove it.

Signed-off-by: Ed Santiago <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue
Projects
None yet
Development

No branches or pull requests

3 participants