Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman logs --since --follow: missing output #17616

Closed
edsantiago opened this issue Feb 23, 2023 · 0 comments · Fixed by #17653
Closed

podman logs --since --follow: missing output #17616

edsantiago opened this issue Feb 23, 2023 · 0 comments · Fixed by #17653
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

New flake:

not ok 108 podman logs - --since --follow journald
...
$ podman logs --since 0.1s -f T37slH9xww
timeout: sending signal TERM to command ?/var/tmp/go/src/github.com/containers/podman/bin/podman?
[ rc=124 (expected) ]
#/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
#|     FAIL: logs --since -f on running container works
#| expected: =~ \^wxTfKjwkoo
#|         >    timeout: sending signal TERM to command.\*
#|   actual:    timeout: sending signal TERM to command ?/var/tmp/go/src/github.com/containers/podman/bin/podman?

Suspiciously similar to #17286, but that one is --until, this one is --since; and that one is k8s-file, this one journald; and that one was remote-only, this one is happening local too.

First seen today, which is -- coincidentally or not -- after the merge of #17305 (new CI VMs) and #17603 (Ed's proposed fix for the other logs --follow flake).
@edsantiago edsantiago added the flakes Flakes from Continuous Integration label Feb 23, 2023
Luap99 added a commit to Luap99/libpod that referenced this issue Feb 28, 2023
@Luap99
fix "podman logs --since --follow" flake
77861d6 
The test should make sure the logs --follow call will log entries that
are created in the future when --since is used and doe not include the
container start event. However it seems the timing is to tight. I think
it was possible that CI logged the line before the logs call was made,
thus it is missing because --since excluded it.

I cannot reproduce so I am not 100% on this but we can reopen the issue
if it still happens.

Fixes containers#17616

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99 Luap99 mentioned this issue Feb 28, 2023
Merged
Luap99 added a commit to Luap99/libpod that referenced this issue Mar 16, 2023
@Luap99
fix "podman logs --since --follow" flake
1a3a559 
The test should make sure the logs --follow call will log entries that
are created in the future when --since is used and doe not include the
container start event. However it seems the timing is to tight. I think
it was possible that CI logged the line before the logs call was made,
thus it is missing because --since excluded it.

I cannot reproduce so I am not 100% on this but we can reopen the issue
if it still happens.

Fixes containers#17616

Signed-off-by: Paul Holzinger <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix "podman logs --since --follow" flake Luap99/libpod
1 participant
@edsantiago