Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new pasta system test fails: podman networking with pasta(1) - Local forwarder, IPv4 #17074

Closed
Luap99 opened this issue Jan 11, 2023 · 13 comments · Fixed by #17713
Closed

new pasta system test fails: podman networking with pasta(1) - Local forwarder, IPv4 #17074

Luap99 opened this issue Jan 11, 2023 · 13 comments · Fixed by #17713
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. pasta pasta(1) bugs or features

Comments

@Luap99
Copy link
Member

Luap99 commented Jan 11, 2023

The new VM images include pasta: #16525
One test is failing for unknown reasons, I can reproduce locally as well.

[+1142s] not ok 424 podman networking with pasta(1) - Local forwarder, IPv4
         # (from function `die' in file test/system/[helpers.bash, line 541](https://github.com/containers/podman/blob/193bac1b5deaf39ed4e04e903ddac09764dd4295/test/system/helpers.bash#L541),
         #  from function `run_podman' in file test/system/[helpers.bash, line 225](https://github.com/containers/podman/blob/193bac1b5deaf39ed4e04e903ddac09764dd4295/test/system/helpers.bash#L225),
         #  in test file test/system/[505-networking-pasta.bats, line 340](https://github.com/containers/podman/blob/193bac1b5deaf39ed4e04e903ddac09764dd4295/test/system/505-networking-pasta.bats#L340))
         #   `run_podman run --dns 198.51.100.1 \' failed
         # $ podman rm -t 0 --all --force --ignore
         # $ podman ps --all --external --format {{.ID}} {{.Names}}
         # $ podman images --all --format {{.Repository}}:{{.Tag}} {{.ID}}
         # quay.io/libpod/testimage:20221018 f5a99120db64
         # $ podman run --dns 198.51.100.1 --net=pasta:--dns-forward,198.51.100.1 quay.io/libpod/testimage:20221018 nslookup 127.0.0.1
         # ;; connection timed out; no servers could be reached
         # [ rc=1 (** EXPECTED 0 **) ]
         # #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
         # #| FAIL: exit code is 1; expected 0
         # #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

From https://api.cirrus-ci.com/v1/artifact/task/5686752053035008/html/sys-remote-fedora-37-rootless-host.log.html

I am going to skip this one for now so we can merge the image update and we can unskip it once this is fixed.

@edsantiago
Copy link
Member

When you add the skip, could you format it as skip "FIXME: #17074: pasta broken on new f37 images" or something like that, that includes botk skip, and #17074 on the same line? I have a script that looks for those and checks github for closed issues. Thanks.

@Luap99 Luap99 added kind/bug Categorizes issue or PR as related to a bug. pasta pasta(1) bugs or features labels Jan 11, 2023
Luap99 added a commit to Luap99/libpod that referenced this issue Jan 19, 2023
It is not working in CI and locally, I filed containers#17074 to track it so we
can fix it later.

Signed-off-by: Paul Holzinger <[email protected]>
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Feb 19, 2023

@Luap99 What is happening with this one?

@Luap99
Copy link
Member Author

Luap99 commented Feb 20, 2023

waiting on upstream to fix it
cc @sbrivio-rh

@sbrivio-rh
Copy link
Collaborator

Right, I forgot to update this ticket, thanks @Luap99 for the reminder.

I couldn't find any actual issue in pasta with this regard, I suspect there's an issue with how the test sources the address of the resolver.

Issue is on myself anyway, assigning.

@sbrivio-rh
Copy link
Collaborator

I can't assign it to myself, it seems. Feel free to do it if possible. Not that it really matters, this is on my list anyway.

@sbrivio-rh
Copy link
Collaborator

I think this is now fixed in passt-0^20230227.gc538ee8-1.fc37, not yet available in the "testing-updates" repositories because I'm still waiting for the previous version to reach "stable".

The issue should be fixed by:
https://passt.top/passt/commit/?id=bad252687271c0255f6a077f19cbc19aa0427f8d

we had captures available from this report, which made debugging quite straightforward.

I'll submit a merge request and ask to update CI images once I can finally get the updated version in Fedora 37 repositories.

@sbrivio-rh
Copy link
Collaborator

@cevich This issue should be fixed in passt-0^20230227.gc538ee8-1.fc37 and I could submit a merge request (re-enabling the test) to try it out. That package version is still in the "testing" repository though, so I wonder: would it take less effort for you if we just used "stable" packages (and waited a bit here... but also in the general case)?

@cevich
Copy link
Member

cevich commented Mar 7, 2023

The point of CI is to try and catch problems early. But you're insight is also accurate, in that we don't want CI to be a PITA of constant updates. In the past for "new" technologies with a lot of churn, we've simply setup CI to grab & use the latest/greatest upstream builds. Bypassing distro packaging entirely. Then later, once the churn settled down, we adjusted accordingly.

That said, I'm not bothered by building new images every other week or so. More than that and it starts to feel like a hassle. I'm kind of on the fence with Pasta, it seems (IMHO) stable enough, without "too much" churn that the distro-packages are okay for CI. Do you feel differently?

@sbrivio-rh
Copy link
Collaborator

That said, I'm not bothered by building new images every other week or so. More than that and it starts to feel like a hassle.

Okay, thanks, that's what I needed to know. :)

I'm kind of on the fence with Pasta, it seems (IMHO) stable enough, without "too much" churn that the distro-packages are okay for CI. Do you feel differently?

No no, I also think so.

Besides, I maintain both Debian and Fedora packages, so I'm updating them whenever there's an issue that looks critical enough (including anything that might make the related Podman tests fail).

I just wanted to get an understanding of how frequently I can reasonably ask you to update images, because I have no clue about the effort involved.

...so, yeah, if you could update the Fedora image to use passt-0^20230227.gc538ee8-1.fc37 (https://bodhi.fedoraproject.org/updates/FEDORA-2023-ae66901b6a) and the Debian image to use passt (0.0~git20230227.c538ee8-1) (it's already in unstable) at some point this week, that would be great, so I can hopefully re-enable this CI test. Thanks!

@cevich
Copy link
Member

cevich commented Mar 7, 2023

I have no clue about the effort involved.

Neither do I lol. Most of the time it's just a matter of opening a PR and waiting. But every now and again a monkey-wrench or blob of duct-tape falls into the gears. Let's hope it's the former and not the later...

@cevich
Copy link
Member

cevich commented Mar 7, 2023

...yay, @sbrivio-rh the build went smoothly. Use c20230307t192532z-f37f36d12 as the IMAGE_SUFFIX in .cirrus.yml for passt-0^20230227.gc538ee8-1.fc37.

@sbrivio-rh
Copy link
Collaborator

@cevich great, thanks a lot! I'll try in a bit.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. pasta pasta(1) bugs or features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants