Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman-remote restart: Error sending SIGKILL: container state improper: stopped #16505

Closed
edsantiago opened this issue Nov 14, 2022 · 1 comment · Fixed by #16522
Closed

podman-remote restart: Error sending SIGKILL: container state improper: stopped #16505

edsantiago opened this issue Nov 14, 2022 · 1 comment · Fixed by #16522
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

Another signal flake. Only seen once int remote f37 root:

# podman-remote [options] start 755ed1a8ac74984410bd7817cec045e56038e06a2133ab9592e70bc9da623c62
755ed1a8ac74984410bd7817cec045e56038e06a2133ab9592e70bc9da623c62
# podman-remote [options] restart 755ed1a8ac74984410bd7817cec045e56038e06a2133ab9592e70bc9da623c62
open pidfd: No such process
Error: sending SIGKILL to container 755ed1a8ac74984410bd7817cec045e56038e06a2133ab9592e70bc9da623c62: container state improper: stopped

Looks exactly the same as #16142, down to the "pidfd" message, but this one is in restart not rm.
@vrothberg
Copy link
Member

I think a podman start **-a** should help the test. The race on the state transition remains for sure.

edsantiago added a commit to edsantiago/libpod that referenced this issue Nov 15, 2022
@edsantiago
e2e tests: fix restart race
58869dc 
It's so easy to forget that "podman start" is nonblocking.
So podman create, start, restart has a race where "restart"
can run before the container actually starts.

Solution: start --attach. Thanks to @vrothberg for noticing that.

There are still a handful of other suspicious-looking restarts
in this test, but all involve "top" which of course has to be
detached. Since those don't have any flakes that I know of, I
choose to ignore them.

Fixes: containers#16505

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago edsantiago mentioned this issue Nov 15, 2022
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

e2e tests: fix restart race edsantiago/libpod
2 participants
@edsantiago @vrothberg