Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman system df: usability issues with --format, --verbose #16204

Closed
edsantiago opened this issue Oct 17, 2022 · 2 comments · Fixed by #16234
Closed

podman system df: usability issues with --format, --verbose #16204

edsantiago opened this issue Oct 17, 2022 · 2 comments · Fixed by #16234
Assignees
@jakecorrenti
Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

First: the two should not be allowed together:

$ bin/podman system df --format '{{.Type}}' --verbose
[spits out the --verbose output]

Second: --format json is not implemented:

$ bin/podman system df --format json
json
json
json

And, third, there is no command-completion help for --format:

$ bin/podman __completeNoDesc system df --format '{{.'
:4
Completion ended with directive: ShellCompDirectiveNoFileComp
@rhatdan rhatdan added the Good First Issue This issue would be a good issue for a first time contributor to undertake. label Oct 17, 2022
@jakecorrenti
Copy link
Member

Can I give this a shot

@rhatdan
Copy link
Member

rhatdan commented Oct 18, 2022

Go for it.

@jakecorrenti jakecorrenti mentioned this issue Oct 20, 2022
Merged
jakecorrenti pushed a commit to jakecorrenti/podman that referenced this issue Oct 21, 2022
Fix system df issues with -f and -v
e5032a8 
Fixed the issue of `--format` and `--verbose` flags being allowed in
combination with one another.

Implemented functionality for `--format json` or `--format '{{ json }}' `.

Implemented command-completion help for `--format`.

Fixes: containers#16204

Signed-off-by: Jake Correnti <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakecorrenti jakecorrenti

Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix system df issues with -f and -v jakecorrenti/podman
3 participants
@edsantiago @rhatdan @jakecorrenti