Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to save an image as a 'docker-dir' format on remote environment #15897

Closed
sstosh opened this issue Sep 22, 2022 · 10 comments · Fixed by #18563
Closed

Failed to save an image as a 'docker-dir' format on remote environment #15897

sstosh opened this issue Sep 22, 2022 · 10 comments · Fixed by #18563
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote stale-issue

Comments

@sstosh
Copy link
Contributor

sstosh commented Sep 22, 2022

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

podman-remote save --format docker-dir saves an image as a docker-archive format.

Describe the results you received:

An image is saved as docker-archive format.

# podman-remote save --format docker-dir -o /root/hoge quay.io/libpod/testimage:20220615

# ls /root/hoge
5f70bf18a086007016e948b04aed3b82103a36bea41755b6cddfaf10ace3c6ef.tar
830537cf97f8edabf3c9defa4b0e1d5300728c5897af15ab6f2ae9c5fba36c04
d376924959cf31ee3dcd95c8079b2cc3feb1655a7182bdc638d8becfe377183c.tar
eb752aaf0876f1dc9ef8fabb9c2cc3eadd77f58d3ef6280f15451640488b289c
f26aa69bb3f3de470d358b6c4e7f9de8ca165ef7f1689af1cdd446902dc27928.json
manifest.json
repositories

Describe the results you expected:

An image is saved as docker-dir format.

# podman-remote save --format docker-dir -o /root/hoge quay.io/libpod/testimage:20220615

# ls /root/hoge
5f70bf18a086007016e948b04aed3b82103a36bea41755b6cddfaf10ace3c6ef  manifest.json
d376924959cf31ee3dcd95c8079b2cc3feb1655a7182bdc638d8becfe377183c  version
f26aa69bb3f3de470d358b6c4e7f9de8ca165ef7f1689af1cdd446902dc27928

Additional information you deem important (e.g. issue happens only occasionally):

Succeeded to save a image as a docker-dir format on local environment.

# podman save --format docker-dir -o /root/hoge quay.io/libpod/testimage:20220615
Copying blob d376924959cf done
Copying blob 5f70bf18a086 done
Copying config f26aa69bb3 done
Writing manifest to image destination
Storing signatures

# ls /root/hoge
5f70bf18a086007016e948b04aed3b82103a36bea41755b6cddfaf10ace3c6ef  manifest.json
d376924959cf31ee3dcd95c8079b2cc3feb1655a7182bdc638d8becfe377183c  version
f26aa69bb3f3de470d358b6c4e7f9de8ca165ef7f1689af1cdd446902dc27928
podman-remote version
Client:       Podman Engine
Version:      4.3.0-dev
API Version:  4.3.0-dev
Go Version:   go1.18.3
Git Commit:   ecaefee43495eed3e387b5cdbd416d85ddaa2254
Built:        Thu Sep 22 10:07:10 2022
OS/Arch:      linux/amd64

Server:       Podman Engine
Version:      4.3.0-dev
API Version:  4.3.0-dev
Go Version:   go1.18.3
Git Commit:   ecaefee43495eed3e387b5cdbd416d85ddaa2254
Built:        Thu Sep 22 10:06:47 2022
OS/Arch:      linux/amd64
podman-remote info
host:
  arch: amd64
  buildahVersion: 1.28.0-dev
  cgroupControllers:
  - cpuset
  - cpu
  - io
  - memory
  - hugetlb
  - pids
  - misc
  cgroupManager: systemd
  cgroupVersion: v2
  conmon:
    package: conmon-2.1.0-2.fc36.x86_64
    path: /usr/bin/conmon
    version: 'conmon version 2.1.0, commit: '
  cpuUtilization:
    idlePercent: 99.92
    systemPercent: 0.02
    userPercent: 0.06
  cpus: 12
  distribution:
    distribution: fedora
    variant: server
    version: "36"
  eventLogger: journald
  hostname: fedora36
  idMappings:
    gidmap: null
    uidmap: null
  kernel: 5.18.11-200.fc36.x86_64
  linkmode: dynamic
  logDriver: journald
  memFree: 6102122496
  memTotal: 8326590464
  networkBackend: netavark
  ociRuntime:
    name: crun
    package: crun-1.5-1.fc36.x86_64
    path: /usr/bin/crun
    version: |-
      crun version 1.5
      commit: 54ebb8ca8bf7e6ddae2eb919f5b82d1d96863dea
      spec: 1.0.0
      +SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +CRIU +YAJL
  os: linux
  remoteSocket:
    exists: true
    path: unix:///run/podman/podman.sock
  security:
    apparmorEnabled: false
    capabilities: CAP_CHOWN,CAP_DAC_OVERRIDE,CAP_FOWNER,CAP_FSETID,CAP_KILL,CAP_NET_BIND_SERVICE,CAP_SETFCAP,CAP_SETGID,CAP_SETPCAP,CAP_SETUID,CAP_SYS_CHROOT
    rootless: false
    seccompEnabled: true
    seccompProfilePath: /usr/share/containers/seccomp.json
    selinuxEnabled: true
  serviceIsRemote: true
  slirp4netns:
    executable: /usr/bin/slirp4netns
    package: slirp4netns-1.2.0-0.2.beta.0.fc36.x86_64
    version: |-
      slirp4netns version 1.2.0-beta.0
      commit: 477db14a24ff1a3de3a705e51ca2c4c1fe3dda64
      libslirp: 4.6.1
      SLIRP_CONFIG_VERSION_MAX: 3
      libseccomp: 2.5.3
  swapFree: 8325689344
  swapTotal: 8325689344
  uptime: 5h 33m 59.00s (Approximately 0.21 days)
plugins:
  authorization: null
  log:
  - k8s-file
  - none
  - passthrough
  - journald
  network:
  - bridge
  - macvlan
  volume:
  - local
registries:
  search:
  - registry.fedoraproject.org
  - registry.access.redhat.com
  - docker.io
  - quay.io
store:
  configFile: /usr/share/containers/storage.conf
  containerStore:
    number: 0
    paused: 0
    running: 0
    stopped: 0
  graphDriverName: overlay
  graphOptions:
    overlay.mountopt: nodev,metacopy=on
  graphRoot: /var/lib/containers/storage
  graphRootAllocated: 106285760512
  graphRootUsed: 20381958144
  graphStatus:
    Backing Filesystem: xfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Using metacopy: "true"
  imageCopyTmpDir: /var/tmp
  imageStore:
    number: 1
  runRoot: /run/containers/storage
  volumePath: /var/lib/containers/storage/volumes
version:
  APIVersion: 4.3.0-dev
  Built: 1663808807
  BuiltTime: Thu Sep 22 10:06:47 2022
  GitCommit: ecaefee43495eed3e387b5cdbd416d85ddaa2254
  GoVersion: go1.18.3
  Os: linux
  OsArch: linux/amd64
  Version: 4.3.0-dev

Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide? (https://github.com/containers/podman/blob/main/troubleshooting.md)

Yes

Additional environment details (AWS, VirtualBox, physical, etc.):
KVM, fedora36

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 22, 2022
@github-actions github-actions bot added the remote Problem is in podman-remote label Sep 22, 2022
@rhatdan
Copy link
Member

rhatdan commented Sep 22, 2022

@vrothberg is this even something we should support on remote?

@vrothberg
Copy link
Member

@vrothberg is this even something we should support on remote?

We do support it. Looks like an unfortunate regression. I get an EPERM when trying that. Screams to have a look at the tests.

@vrothberg
Copy link
Member

@boaz0, interested in tackling this issue?

@boaz0
Copy link
Collaborator

boaz0 commented Sep 27, 2022

sure, assign it to me. 😄

@vrothberg
Copy link
Member

Thanks!

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Oct 29, 2022

@boaz0 any update on this?

@boaz0
Copy link
Collaborator

boaz0 commented Nov 18, 2022

Yeah, but I am not done with this. It seems like we didn't have support for that on the API.

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@vrothberg vrothberg self-assigned this May 15, 2023
vrothberg added a commit to vrothberg/libpod that referenced this issue May 15, 2023
Make sure that the directory formats are not just substituted with their
archive counterparts but actually tar'ed up directories.  Also make sure
that the clients don't get chown errors by setting rootless user and
group ID instead of O when running in the user namespace.

Fixes: containers#15897
Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg
Copy link
Member

I opened #18563 to fix the issue.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote stale-issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants