Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: include OSX and windows cross task in CI:DOCS #15189

Closed
Luap99 opened this issue Aug 4, 2022 · 4 comments · Fixed by #15198
Closed

CI: include OSX and windows cross task in CI:DOCS #15189

Luap99 opened this issue Aug 4, 2022 · 4 comments · Fixed by #15198
Assignees
@cevich
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@Luap99
Copy link
Member

Luap99 commented Aug 4, 2022

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

#15174 broke CI because it used CI:DOCS and thus skipped some tasks. In this case the OCX cross task is now failing. Because the OSX cross task also builds docs, it can be effected by docs changes and therefore we should include this in CI:DOCS.

Also excluded is the windows cross task. Since this also builds docs it should be included in CI:DOCS as well.
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 4, 2022
@Luap99
Copy link
Member Author

Luap99 commented Aug 4, 2022

@edsantiago @cevich PTAL
cc @containers/podman-maintainers

@gbraad
Copy link
Member

gbraad commented Aug 4, 2022

It seems 'override' in the text is interpreted as a statement?

@cevich
Copy link
Member

cevich commented Aug 4, 2022

the OSX cross task also builds docs

Ugg, you're right. This is probably my fault. Taking a look.

@cevich cevich self-assigned this Aug 4, 2022
@cevich cevich mentioned this issue Aug 4, 2022
Merged
@cevich
Copy link
Member

cevich commented Aug 4, 2022

Okay #15198 will fix this. Thanks for pointing out the problem.

cevich added a commit to cevich/podman that referenced this issue Aug 4, 2022
@cevich
Cirrus: Run Cross builds in [CI:DOCS] mode
4cea8ad 
Fixes: containers#15189

A while ago I updated the only_if/skip options and forgot that several
"cross build" tasks also build documentation in addition to binaries.  Re-enable
them to execute all the time, except when Cirrus-cron is making our
multi-arch images.

Signed-off-by: Chris Evich <[email protected]>
mheon pushed a commit to mheon/libpod that referenced this issue Aug 10, 2022
@cevich @mheon
Cirrus: Run Cross builds in [CI:DOCS] mode
a19c5a2 
Fixes: containers#15189

A while ago I updated the only_if/skip options and forgot that several
"cross build" tasks also build documentation in addition to binaries.  Re-enable
them to execute all the time, except when Cirrus-cron is making our
multi-arch images.

Signed-off-by: Chris Evich <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cevich cevich

Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cirrus: Run Cross builds in [CI:DOCS] mode cevich/podman
3 participants
@gbraad @cevich @Luap99