Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman generate kube prints Secret: null #15156

Closed
dilyanpalauzov opened this issue Aug 2, 2022 · 0 comments · Fixed by #15158
Closed

podman generate kube prints Secret: null #15156

dilyanpalauzov opened this issue Aug 2, 2022 · 0 comments · Fixed by #15158
Assignees
@cdoern
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@dilyanpalauzov
Copy link
Contributor 

$  podman generate kube vigorous_shannon
apiVersion: v1
kind: Pod
metadata:
  …
spec:
  containers:
  …
  volumes:
  - Secret: null
    hostPath:
      path: /home/d/data
      type: Directory
    name: home-d-data-host-0

$ podman version
Client:       Podman Engine
Version:      4.2.0-dev
API Version:  4.2.0-dev
Go Version:   go1.18.4
Git Commit:   fed326d8a6f8d4f7dc490099b29d51fc1754789f
Built:        Sat Jul 30 15:08:11 2022
OS/Arch:      linux/amd64
@cdoern cdoern self-assigned this Aug 2, 2022
@cdoern cdoern mentioned this issue Aug 2, 2022
Merged
cdoern added a commit to cdoern/podman that referenced this issue Aug 3, 2022
@cdoern
add omitempty to Secret in k8s VolumeSource
7df8d80 
Secret was populating a generated kube as `null`. Add omitempty
so that when the volume source is not a secret, we do not print unnecessary info

resolves containers#15156

Signed-off-by: Charlie Doern <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cdoern cdoern

Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add omitempty to Secret in k8s VolumeSource cdoern/podman
2 participants
@dilyanpalauzov @cdoern