-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility to set domainname via REST Endpoint #15102
Comments
Does anyone know what this does in Docker? We can easily add this to the DB, but I don't really know what it would actually do once set? |
domainname is used by NIS and NFS (Perhaps). https://www.geeksforgeeks.org/domainname-command-in-linux-with-examples/ |
I feel like if we support this natively, and both docker-py and docker have it everywhere, we should to. Looking at alot of those unsupported options in podman-py makes me think, with recent changes in podman a lot of those can be supported. I'll put this on my list of api/podman-py related things to do |
I think we need a podman run/create flag as well:
From the cli differences issue #14917 |
@Luap99 sorry for my unfamiliarity here, but this just sets another entry in /etc/hosts right? |
I have no idea, we have to do whatever docker does. I assume it appends the domain to the hostname as well? |
thats what I've found everywhere. Docker has a link to https://man7.org/linux/man-pages/man2/getdomainname.2.html which makes me think that's all it is. So domainnmae has to be specified with hostname... i guess? |
A friendly reminder that this issue had no activity for 30 days. |
in progress |
A friendly reminder that this issue had no activity for 30 days. |
@cdoern how is this coming? |
@rhatdan working on it this week over fall break |
domainname functions similarly to --hostname, it sets the value in /etc/hosts to whatever you speficy in conjunction with --hostname. so if you pass --hostname=foo --domainmame=baz.net, /etc/hosts will get the combined entry and /proc/sys/kernel/domainname will get baz.net resolves containers#15102 Signed-off-by: Charlie Doern <[email protected]>
Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind feature
Description
I'd like to implement possibility to set domainname in podman-py project but according to the podman REST API there is no such option.
Interestingly enough under compact (aka docker compatibility) endpoint there is such parameter, but podman-py (rightfully) does not use this endpoint to create container.
I'm also not seeing this option in cli (to be fair docker up until 1.40~ did not have this option either, but the call on the docker-py worked properly).
The inspect in podman shows the empty value, which makes me wonder whether this was forgotten or is there other option to fill the domainname?
Is there possibility to add possibility to add domainname, to at least REST endpoint ?
The text was updated successfully, but these errors were encountered: